[repository-quality] Repository Quality Improvement Report - Context Propagation & Process Cancellability

[github-actions[bot]]

🎯 Repository Quality Improvement Report - Context Propagation & Process Cancellability

Analysis Date: 2026-06-03
Focus Area: Context Propagation & Process Cancellability
Strategy Type: Custom

Executive Summary

A scan of all subprocess invocations reveals 109 bare exec.Command calls vs only 24 exec.CommandContext calls — meaning 82% of subprocesses cannot be cancelled, timed out, or interrupted by a caller-provided context. This directly undermines the CLI's signal.NotifyContext interrupt handling: when a user presses Ctrl+C, in-flight git operations are orphaned.

The problem is most severe in pkg/cli/run_push.go, where functions receive ctx context.Context for compilation but ignore it for 4 git subprocess calls (commit, push, add, diff). Similarly, pkg/cli/git.go (18 bare calls) and pkg/cli/pr_command.go (20 bare calls) contain foundational helpers with no context parameters. The repository already has a ctxbackground linter — extending it to cover exec.Command would prevent future regressions automatically.

Full Analysis Report

Current State Assessment

Metric	Value	Status
exec.Command bare calls	109	❌
exec.CommandContext calls	24	✅
Subprocess cancellability rate	18%	❌
Files with ctx param using bare exec.Command	8	❌
Existing ctx misuse linter	ctxbackground present	⚠️

Top offenders:

File	Bare calls	Has ctx?
pkg/cli/pr_command.go	20	No (helpers lack param)
pkg/cli/git.go	18	No (helpers lack param)
pkg/parser/remote_fetch.go	13	No (helpers lack param)
pkg/cli/trial_repository.go	8	Yes — ignored
pkg/cli/run_push.go	4	Yes — ignored

Findings

Strengths

• exec.CommandContext used correctly in pkg/workflow/docker_validation.go and the RunGHContext family
• signal.NotifyContext used in forecast.go for interrupt propagation
• ctxbackground linter already exists in pkg/linters/

Areas for Improvement

• Critical: run_push.go receives ctx for compilation but drops it before git subprocess calls on lines ~426, 439, 582, 596
• High: git.go core helpers (getCurrentBranch, commitChanges, pushBranch) lack ctx parameter, blocking propagation
• High: pr_command.go 20-call helper chain (applyPatchToRepo, createTransferPR) has no ctx
• Medium: remote_fetch.go git clone/ls-remote calls (13 occurrences) can run for minutes with no timeout
• Medium: Linter gap — ctxbackground only flags context.Background(), not bare exec.Command

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Improvement Tasks

Task 1: Fix run_push.go — Pass ctx to Git Subprocesses

Priority: High
Estimated Effort: Small

Description: pushWorkflowFiles and helpers receive no ctx even though callers do. Add ctx context.Context to pushWorkflowFiles and replace 4 bare exec.Command calls (lines ~426, 439, 582, 596) with exec.CommandContext(ctx, ...).

Acceptance Criteria:

• pushWorkflowFiles accepts ctx context.Context as first parameter
• All 4 exec.Command("git", ...) calls replaced with exec.CommandContext(ctx, "git", ...)
• Callers pass their context; make fmt and tests pass

Code Region: pkg/cli/run_push.go

In `pkg/cli/run_push.go`, add `ctx context.Context` as the first parameter to `pushWorkflowFiles` (line 412). Replace every `exec.Command("git", ...)` call in that function with `exec.CommandContext(ctx, "git", ...)`. Update all call sites to pass their available context. Run `make fmt` and existing tests.

---

Task 2: Add Context to pkg/cli/git.go Core Helpers

Priority: High
Estimated Effort: Medium

Description: Add ctx context.Context to getCurrentBranch, createAndSwitchBranch, switchBranch, commitChanges, pushBranch, checkCleanWorkingDirectory, and checkWorkflowFileStatus. Replace all 18 bare exec.Command calls with exec.CommandContext(ctx, ...). Update callers to pass cmd.Context() from cobra handlers.

Acceptance Criteria:

• All 7 helpers accept ctx context.Context as first parameter
• All 18 bare calls converted; no new context.Background() escapes introduced
• make fmt and tests pass

Code Region: pkg/cli/git.go

In `pkg/cli/git.go`, add `ctx context.Context` as the first parameter to: `getCurrentBranch`, `createAndSwitchBranch`, `switchBranch`, `commitChanges`, `pushBranch`, `checkCleanWorkingDirectory`, and `checkWorkflowFileStatus`. Replace all `exec.Command("git", ...)` calls with `exec.CommandContext(ctx, "git", ...)`. In cobra RunE handlers, use `cmd.Context()`. Run `make fmt` and verify tests pass.

---

Task 3: Thread Context Through pr_command.go Helper Chain

Priority: Medium
Estimated Effort: Medium

Description: applyPatchToRepo (line 261), createTransferPR (line 411), and transferPR (line 540) account for 20 bare calls in a long-running git operation sequence. Add ctx and use exec.CommandContext. For cleanup/abort operations, use context.WithTimeout(context.Background(), 10*time.Second) so cleanup still runs after cancellation.

Acceptance Criteria:

• transferPR, applyPatchToRepo, createTransferPR accept ctx context.Context
• All 20 bare calls converted; cleanup operations use a fresh short-timeout context
• make fmt and tests pass

Code Region: pkg/cli/pr_command.go

In `pkg/cli/pr_command.go`, add `ctx context.Context` to `transferPR`, `applyPatchToRepo`, and `createTransferPR`. Replace all 20 `exec.Command("git", ...)` calls with `exec.CommandContext(ctx, "git", ...)`. For abort/cleanup calls like `exec.Command("git", "am", "--abort")`, use `context.WithTimeout(context.Background(), 10*time.Second)`. Thread `cmd.Context()` from cobra RunE. Run `make fmt` and tests.

---

Task 4: Extend ctxbackground Linter to Flag exec.Command in Context-Aware Functions

Priority: High
Estimated Effort: Small

Description: Extend (or add companion execnocontext linter) to flag exec.Command(...) calls inside functions that have a context.Context parameter in scope, suggesting exec.CommandContext(ctx, ...). Register and add test data.

Acceptance Criteria:

• Linter flags exec.Command when ctx param is in scope with message suggesting exec.CommandContext
• Test data covers flagged and unflagged cases
• Registered in linters registry; make lint passes

Code Region: pkg/linters/ctxbackground/ctxbackground.go

In `pkg/linters/ctxbackground/` (or a new `pkg/linters/execnocontext/`), add analysis that detects `exec.Command` calls (from `os/exec`) inside functions with a `context.Context` parameter. Emit: `"use exec.CommandContext with the context.Context parameter instead of exec.Command"`. Add testdata. Register the linter. Run `make lint`.

---

Task 5: Thread Context Into remote_fetch.go Git Operations

Priority: Medium
Estimated Effort: Medium

Description: remote_fetch.go has 13 bare exec.Command calls for network-touching git operations (clone, ls-remote, archive). Add ctx context.Context to resolveRefToSHAViaGit, downloadFileViaGit, downloadFileViaGitClone, and getOrCreateListRepoClone. Update public API (DownloadFileFromGitHubForHost, ResolveRefToSHAForHost) to accept ctx.

Acceptance Criteria:

• 4 internal helpers accept ctx; all 13 bare calls converted
• Public API functions updated with ctx parameter; callers updated
• make fmt and tests pass

Code Region: pkg/parser/remote_fetch.go

In `pkg/parser/remote_fetch.go`, add `ctx context.Context` to `resolveRefToSHAViaGit`, `downloadFileViaGit`, `downloadFileViaGitClone`, and `getOrCreateListRepoClone`. Replace 13 `exec.Command("git", ...)` calls with `exec.CommandContext(ctx, "git", ...)`. Update public API `DownloadFileFromGitHubForHost` and `ResolveRefToSHAForHost` to accept ctx. Update all callers. Run `make fmt` and tests.

---

📊 Historical Context

Previous Focus Areas

Date	Focus Area	Custom
2026-05-20	Large File Refactoring	Y
2026-05-21	Error Message Quality	Y
2026-05-22	MCP Integration Robustness	Y
2026-05-25	Test Infrastructure & Build Tags	Y
2026-05-26	Go Dependency Hygiene	Y
2026-05-27	Agentic Workflow Runtime Safety	Y
2026-05-28	Semantic Constant Adoption	Y
2026-05-29	CI/CD Pipeline Resilience	N
2026-06-01	Command Registration Architecture	Y
2026-06-02	Debug Observability & Build Tag Compliance	Y

🎯 Recommendations

Immediate Actions

1. Fix run_push.go — git ops during cancel corrupt state — Priority: High
2. Extend ctxbackground linter for exec.Command — self-enforcing — Priority: High

Short-term

1. Add ctx to git.go helpers — enables full CLI cancellation — Priority: High
2. Thread ctx through pr_command.go — Priority: Medium

Long-term

1. Migrate remote_fetch.go public API — enables network op timeouts — Priority: Medium

📈 Success Metrics

• Subprocess cancellability: 18% → 90%+
• Bare exec.Command calls: 109 → <15
• Linter coverage: +1 new enforcement rule

References: §26890744714

Generated by ⚡ Repository Quality Improvement Agent · sonnet46 1.5M · ◷

• expires on Jun 4, 2026, 2:26 PM UTC

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-04T14:26:25.924Z.

Closed by Workflow