[repository-quality] Command Registration Architecture Consolidation — main.go at 940 Lines

[github-actions[bot]]

🎯 Repository Quality Improvement Report - Command Registration Architecture

Analysis Date: 2026-06-01 Focus Area: Command Registration Architecture Consolidation Strategy Type: Custom

Executive Summary

cmd/gh-aw/main.go has grown to 940 lines because 7 cobra commands (new, remove, enable, disable, compile, run, version) remain inline with full RunE implementations, while 30+ other commands follow the established pkg/cli/New*Command() factory pattern. The init() function is 431 lines. The highest-impact violations are compileCmd (136 lines) and runCmd (86 lines) — the two most user-facing CLI operations — which are untestable without running the full binary. Estimated main.go size after full migration: ~250 lines.

Full Analysis Report

Current State Assessment

Metric	Value	Status
cmd/gh-aw/main.go total lines	940	❌
Commands inline in main.go	7	❌
init() function size	431 lines	⚠️
main() function size	41 lines	✅
Commands in pkg/cli/ pattern	30+	✅
compileCmd inline size	136 lines	❌
runCmd inline size	86 lines	❌

Strengths

• 30+ commands already follow the New*Command() pattern
• main() itself is small (41 lines)
• pkg/cli/ commands are independently unit-testable

Areas for Improvement

• [HIGH] compileCmd — most-used CLI command, inline RunE prevents unit testing
• [HIGH] runCmd — inline with substantial flag parsing and delegation logic
• [MEDIUM] newCmd (58 lines) — interactive workflow creation not in pkg/cli/
• [MEDIUM] init() 431 lines — flag registration bloat that would shrink with migration
• [LOW] removeCmd, enableCmd, disableCmd, versionCmd — small but inconsistent

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Task 1: Migrate compileCmd to pkg/cli/compile_command.go

Priority: High | Effort: Medium | Code Region: cmd/gh-aw/main.go lines 234–369

Description: Extract the inline compileCmd (lines 234–369) into NewCompileCommand(validateEngine func(string) error) *cobra.Command in pkg/cli/compile_command.go. Move all flag registrations from init() into the factory. Wire via rootCmd.AddCommand(cli.NewCompileCommand(validateEngine)).

Acceptance Criteria:

• pkg/cli/compile_command.go with NewCompileCommand() factory exists
• All compile flags registered inside the factory (not in init())
• var compileCmd removed from main.go
• make build && make test-unit pass; ./gh-aw compile --help unchanged

Migrate `compileCmd` from `cmd/gh-aw/main.go` (lines 234–369 + flag registrations in `init()`) to a new `pkg/cli/compile_command.go` file. Create `func NewCompileCommand(validateEngine func(string) error) *cobra.Command` following the pattern of `pkg/cli/logs_command.go`. Move all `compileCmd.Flags().*` registrations from `init()` into the factory. Update `main.go` to call `rootCmd.AddCommand(cli.NewCompileCommand(validateEngine))`. Run `make build && make fmt && ./gh-aw compile --help` to verify. Run `make agent-report-progress` before creating a PR.

---

Task 2: Migrate runCmd to pkg/cli/run_command.go

Priority: High | Effort: Medium | Code Region: cmd/gh-aw/main.go lines 370–455

Description: Extract runCmd (lines 370–455) into NewRunCommand(validateEngine func(string) error) *cobra.Command in pkg/cli/run_command.go. Move all run flag registrations from init().

Acceptance Criteria:

• pkg/cli/run_command.go with NewRunCommand() factory exists
• All run flags registered inside factory; var runCmd removed from main.go
• make build && make test-unit pass; ./gh-aw run --help unchanged

Migrate `runCmd` from `cmd/gh-aw/main.go` (lines 370–455 + `runCmd.Flags()` registrations in `init()`) to `pkg/cli/run_command.go`. Create `func NewRunCommand(validateEngine func(string) error) *cobra.Command` following the `pkg/cli/` factory pattern. Move all flag registrations into the factory. Update `main.go` to use `rootCmd.AddCommand(cli.NewRunCommand(validateEngine))`. Run `make build && make fmt && ./gh-aw run --help`. Run `make agent-report-progress` before PR.

---

Task 3: Migrate newCmd, removeCmd, enableCmd, disableCmd to pkg/cli/

Priority: Medium | Effort: Medium | Code Region: cmd/gh-aw/main.go lines 109–233

Acceptance Criteria:

• Four new files: pkg/cli/new_command.go, remove_command.go, enable_command.go, disable_command.go
• Inline var *Cmd declarations removed from main.go
• make build && make test-unit pass; --help for all four commands unchanged

Migrate `newCmd` (lines 109–166), `removeCmd` (167–193), `enableCmd` (194–212), `disableCmd` (213–233) from `cmd/gh-aw/main.go` to individual files in `pkg/cli/`. Each gets a `New*Command()` factory. Move any flag registrations from `init()` into each factory. Update `main.go` wiring. Run `make build && make fmt`. Verify `./gh-aw new --help`, `./gh-aw remove --help`, etc. Run `make agent-report-progress` before PR.

---

Task 4: Add Unit Tests for compile and run Commands

Priority: Medium | Effort: Small | Code Region: pkg/cli/compile_command_test.go, pkg/cli/run_command_test.go

Acceptance Criteria:

• Both test files have //go:build !integration tag
• Tests: factory returns non-nil command, correct Use/Short, flag defaults, invalid engine returns error
• make test-unit passes

After Tasks 1–2 complete, add unit tests in `pkg/cli/compile_command_test.go` and `pkg/cli/run_command_test.go`. Each needs `//go:build !integration` at top. Test: `NewCompileCommand`/`NewRunCommand` returns non-nil, Use/Short fields correct, key flags registered with correct defaults, invalid engine name returns an error from RunE. Use `testify/assert` with messages. Run `make lint` and `go test -v -run 'TestNewCompile|TestNewRun' ./pkg/cli/`. Run `make agent-report-progress` before PR.

---

📊 Historical Context

Previous Focus Areas

Date	Focus Area	Custom
2026-05-20	Large File Refactoring & Maintainability	Y
2026-05-21	Error Message Quality & User Experience	Y
2026-05-22	MCP Integration Robustness & Error Recovery	Y
2026-05-25	Test Infrastructure & Build Tag Compliance	Y
2026-05-26	Go Dependency Hygiene & Import Path Consistency	Y
2026-05-27	Agentic Workflow Runtime Safety & Compliance	Y
2026-05-28	Semantic Constant Adoption & Magic String Elimination	Y
2026-05-29	CI/CD Pipeline Resilience: Timeout & Concurrency Coverage	N

📈 Success Metrics

• main.go line count: 940 → ~250
• init() size: 431 → ~80 lines
• Commands in pkg/cli/ pattern: 30 → 37 (100%)

References:

• §26762215893

Generated by ⚡ Repository Quality Improvement Agent · sonnet46 2.2M · ◷

• expires on Jun 2, 2026, 2:55 PM UTC

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-02T14:55:00.579Z.

Closed by Workflow