fix: harden copilot steering state load and save

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/10b67751-6800-491f-97fd-2b102bbee5ca

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

actions/setup/js/copilot_steering_hook.cjs

@@ -3,13 +3,15 @@
 "use strict";
 
 const fs = require("fs");
+const path = require("path");
 
 const DEFAULT_TIMEOUT_MINUTES = 30;
 const DEFAULT_TIME_WARNING_MINUTES = 5;
 const DEFAULT_TIME_CRITICAL_MINUTES = 2;
 const DEFAULT_RUN_WARNING_REMAINING = 2;
 const DEFAULT_RUN_CRITICAL_REMAINING = 1;
 const DEFAULT_STATE_PATH = "/tmp/gh-aw/copilot-steering-state.json";
+const MS_PER_MINUTE = 60000;
 
 /**
  * @typedef {{
@@ -77,7 +79,11 @@ function loadState(statePath) {
       return null;
     }
     const raw = fs.readFileSync(statePath, "utf8");
-    return /** @type {SteeringState} */ JSON.parse(raw);
+    const parsed = JSON.parse(raw);
+    if (!isValidSteeringState(parsed)) {
+      return null;
+    }
+    return parsed;
   } catch {
     return null;
   }
@@ -88,9 +94,29 @@ function loadState(statePath) {
  * @param {SteeringState} state
  */
 function saveState(statePath, state) {
+  fs.mkdirSync(path.dirname(statePath), { recursive: true });
   fs.writeFileSync(statePath, JSON.stringify(state), "utf8");
 }
 
+/**
+ * @param {unknown} value
+ * @returns {value is SteeringState}
+ */
+function isValidSteeringState(value) {
+  if (!value || typeof value !== "object") {
+    return false;
+  }
+  const candidate = /** @type {Record<string, unknown>} */ value;
+  return (
+    typeof candidate.startedAtMs === "number" &&
+    Number.isFinite(candidate.startedAtMs) &&
+    typeof candidate.turns === "number" &&
+    Number.isFinite(candidate.turns) &&
+    typeof candidate.warningInjected === "boolean" &&
+    typeof candidate.criticalInjected === "boolean"
+  );
+}
+
 /**
  * @param {unknown} value
  * @returns {number}
@@ -140,7 +166,7 @@ function buildBudgetSummary(remainingMinutes, remainingRuns) {
  */
 function computeSteeringDecision(state, config, timestamp) {
   const nextState = { ...state, turns: state.turns + 1 };
-  const elapsedMinutes = (timestamp - nextState.startedAtMs) / 60000;
+  const elapsedMinutes = (timestamp - nextState.startedAtMs) / MS_PER_MINUTE;
   const remainingMinutes = Number.isFinite(config.timeoutMinutes) ? config.timeoutMinutes - elapsedMinutes : null;
   const remainingRuns = config.maxRuns > 0 ? config.maxRuns - nextState.turns : null;
 

actions/setup/js/copilot_steering_hook.test.cjs

@@ -80,4 +80,29 @@ describe("copilot_steering_hook.cjs", () => {
     expect(result.decision.reason).toContain("CRITICAL");
     expect(result.decision.reason).toContain("minute(s) left");
   });
+
+  it("falls back to initial state when persisted state is malformed-but-parseable", () => {
+    const env = makeTestEnv({
+      GH_AW_TIMEOUT_MINUTES: "10",
+      GH_AW_STEERING_TIME_WARNING_MINUTES: "9.9",
+      GH_AW_STEERING_TIME_CRITICAL_MINUTES: "0.1",
+      GH_AW_COPILOT_MAX_RUNS: "2",
+    });
+    fs.writeFileSync(statePath, "{}", "utf8");
+    const result = handleSteeringEvent("agentStop", { timestamp: 60 * 1000 }, env);
+    expect(result.state.turns).toBe(1);
+    expect(result.state.warningInjected).toBe(true);
+    expect(result.decision).not.toBeNull();
+    expect(result.decision.reason).toContain("minute(s) left");
+  });
+
+  it("creates parent directory before saving state", () => {
+    const env = makeTestEnv();
+    const nestedStatePath = path.join(tempDir, "nested", "deeper", "state.json");
+    env.GH_AW_COPILOT_STEERING_STATE_PATH = nestedStatePath;
+
+    const result = handleSteeringEvent("sessionStart", { timestamp: 1000, source: "new" }, env);
+    expect(result.decision).toBeNull();
+    expect(fs.existsSync(nestedStatePath)).toBe(true);
+  });
 });