refactor(cli): apply immutability improvements to pkg/cli (#18105)

Author: github-actions[bot]

pkg/cli/completions.go

@@ -8,6 +8,7 @@ import (
 	"github.com/github/gh-aw/pkg/fileutil"
 	"github.com/github/gh-aw/pkg/logger"
 	"github.com/github/gh-aw/pkg/parser"
+	"github.com/github/gh-aw/pkg/sliceutil"
 	"github.com/github/gh-aw/pkg/workflow"
 	"github.com/spf13/cobra"
 )
@@ -109,12 +110,9 @@ func CompleteEngineNames(cmd *cobra.Command, args []string, toComplete string) (
 
 	engines := ValidEngineNames()
 
-	var filtered []string
-	for _, engine := range engines {
-		if toComplete == "" || strings.HasPrefix(engine, toComplete) {
-			filtered = append(filtered, engine)
-		}
-	}
+	filtered := sliceutil.Filter(engines, func(engine string) bool {
+		return toComplete == "" || strings.HasPrefix(engine, toComplete)
+	})
 
 	completionsLog.Printf("Found %d matching engines", len(filtered))
 	return filtered, cobra.ShellCompDirectiveNoFileComp
@@ -145,12 +143,12 @@ func CompleteMCPServerNames(workflowFile string) func(cmd *cobra.Command, args [
 			return nil, cobra.ShellCompDirectiveNoFileComp
 		}
 
-		var servers []string
-		for _, config := range mcpConfigs {
-			if toComplete == "" || strings.HasPrefix(config.Name, toComplete) {
-				servers = append(servers, config.Name)
-			}
-		}
+		servers := sliceutil.FilterMap(mcpConfigs,
+			func(config parser.MCPServerConfig) bool {
+				return toComplete == "" || strings.HasPrefix(config.Name, toComplete)
+			},
+			func(config parser.MCPServerConfig) string { return config.Name },
+		)
 
 		completionsLog.Printf("Found %d matching MCP servers", len(servers))
 		return servers, cobra.ShellCompDirectiveNoFileComp

pkg/cli/gateway_logs.go

@@ -24,6 +24,7 @@ import (
 
 	"github.com/github/gh-aw/pkg/console"
 	"github.com/github/gh-aw/pkg/logger"
+	"github.com/github/gh-aw/pkg/sliceutil"
 	"github.com/github/gh-aw/pkg/stringutil"
 	"github.com/github/gh-aw/pkg/timeutil"
 )
@@ -517,13 +518,7 @@ func renderGatewayMetricsTable(metrics *GatewayMetrics, verbose bool) string {
 		output.WriteString("├────────────────────────────┼──────────┼────────────┼───────────┼────────┤\n")
 
 		// Sort servers by request count
-		var serverNames []string
-		for name := range metrics.Servers {
-			serverNames = append(serverNames, name)
-		}
-		sort.Slice(serverNames, func(i, j int) bool {
-			return metrics.Servers[serverNames[i]].RequestCount > metrics.Servers[serverNames[j]].RequestCount
-		})
+		serverNames := getSortedServerNames(metrics)
 
 		for _, serverName := range serverNames {
 			server := metrics.Servers[serverName]
@@ -560,10 +555,7 @@ func renderGatewayMetricsTable(metrics *GatewayMetrics, verbose bool) string {
 			output.WriteString("├──────────────────────────┼───────┼──────────┼──────────┼──────────┤\n")
 
 			// Sort tools by call count
-			var toolNames []string
-			for name := range server.Tools {
-				toolNames = append(toolNames, name)
-			}
+			toolNames := sliceutil.MapToSlice(server.Tools)
 			sort.Slice(toolNames, func(i, j int) bool {
 				return server.Tools[toolNames[i]].CallCount > server.Tools[toolNames[j]].CallCount
 			})
@@ -587,10 +579,7 @@ func renderGatewayMetricsTable(metrics *GatewayMetrics, verbose bool) string {
 
 // getSortedServerNames returns server names sorted by request count
 func getSortedServerNames(metrics *GatewayMetrics) []string {
-	var names []string
-	for name := range metrics.Servers {
-		names = append(names, name)
-	}
+	names := sliceutil.MapToSlice(metrics.Servers)
 	sort.Slice(names, func(i, j int) bool {
 		return metrics.Servers[names[i]].RequestCount > metrics.Servers[names[j]].RequestCount
 	})

pkg/cli/run_interactive.go

@@ -439,8 +439,7 @@ func RunSpecificWorkflowInteractively(ctx context.Context, workflowName string,
 
 // buildCommandString builds the equivalent command string for display
 func buildCommandString(workflowName string, inputs []string, repoOverride, refOverride string, autoMergePRs, push bool, engineOverride string) string {
-	var parts []string
-	parts = append(parts, string(constants.CLIExtensionPrefix), "run", workflowName)
+	parts := []string{string(constants.CLIExtensionPrefix), "run", workflowName}
 
 	// Add inputs
 	for _, input := range inputs {