Daily Perf Improver #27
dsymedaily-perf-improver.lock.yml
on: schedule
Annotations
3 errors and 1 warning
|
agent
Errors detected in agent logs - continuing workflow step (not failing for now)
|
|
agent
Line 4785: NOT SUITABLE for t.Parallel() - parent aggregates results\\nfunc TestMultipleServers(t *testing.T) {\\n setup := setupTest(t)\\n defer setup.cleanup() // Runs before parallel subtests!\\n \\n successCount := 0 // Shared state\\n \\n for _, server := range servers {\\n t.Run(server, func(t *testing.T) {\\n t.Parallel() // ✗ BAD: Parent continues and cleans up\\n successCount++ // ✗ BAD: Race condition\\n })\\n }\\n \\n // ✗ BAD: This runs before parallel subtests execute!\\n if successCount == 0 {\\n t.Error(\\\"No servers succeeded\\\")\\n }\\n}\\n```\\n\\n**Why it fails:**\\n1. `t.Parallel()` pauses subtests until parent function returns\\n2. Parent's `defer cleanup()` executes before subtests resume\\n3. Cleanup deletes resources subtests need\\n4. Parent checks `successCount` before subtests update it\\n\\n**Solution:** Either:\\n- Remove `t.Parallel()` for tests with parent aggregation\\n- Restructure to avoid parent aggregation pattern\\n- Use separate parent/child test functions\"}" (Pattern: Copilot CLI failed command indicator, Raw log: "arguments": "{\"path\": \"/home/runner/work/gh-aw/gh-aw/.github/copilot/instructions/build-performance.md\", \"old_str\...)
|
|
agent
Line 3876: Each child in a list should have a unique "key" prop. (Pattern: Copilot CLI timestamped ERROR messages, Raw log: 2025-11-12T02:39:10.859Z [ERROR] Each child in a list should have a unique "key" prop.)
|
|
agent
Line 3857: Failed to add server %s: %v\\\\nOutput: %s\\\", serverName, err, string(output))\\n\\t\\t\\t\\t\\tfailureCount++\\n\\t\\t\\t\\t} else {\\n\\t\\t\\t\\t\\tt.Logf(\\\"✓ Successfully added server: %s\\\", serverName)\\n\\t\\t\\t\\t\\tsuccessCount++\\n\\n\\t\\t\\t\\t\\t// Verify the workflow file was updated\\n\\t\\t\\t\\t\\tupdatedContent, readErr := os.ReadFile(workflowFile)\\n\\t\\t\\t\\t\\tif readErr != nil {\\n\\t\\t\\t\\t\\t\\tt.Errorf(\\\"Failed to read updated workflow file: %v\\\", readErr)\\n\\t\\t\\t\\t\\t} else {\\n\\t\\t\\t\\t\\t\\tupdatedStr := string(updatedContent)\\n\\t\\t\\t\\t\\t\\tif !strings.Contains(updatedStr, \\\"mcp:\\\") {\\n\\t\\t\\t\\t\\t\\t\\tt.Errorf(\\\"Expected MCP configuration to be added to workflow for server %s\\\", serverName)\\n\\t\\t\\t\\t\\t\\t}\\n\\t\\t\\t\\t\\t}\\n\\t\\t\\t\\t}\\n\\t\\t\\tcase <-time.After(timeout):\\n\\t\\t\\t\\tt.Logf(\\\"Warning: Timeout adding server %s after %v\\\", serverName, timeout)\\n\\t\\t\\t\\tfailureCount++\\n\\t\\t\\t}\", \"new_str\": \"\\t\\t\\tselect {\\n\\t\\t\\tcase err := <-done:\\n\\t\\t\\t\\tif err != nil {\\n\\t\\t\\t\\t\\tt.Logf(\\\"Warning: Failed to add server %s: %v\\\\nOutput: %s\\\", serverName, err, string(output))\\n\\t\\t\\t\\t\\tmu.Lock()\\n\\t\\t\\t\\t\\tfailureCount++\\n\\t\\t\\t\\t\\tmu.Unlock()\\n\\t\\t\\t\\t} else {\\n\\t\\t\\t\\t\\tt.Logf(\\\"✓ Successfully added server: %s\\\", serverName)\\n\\t\\t\\t\\t\\tmu.Lock()\\n\\t\\t\\t\\t\\tsuccessCount++\\n\\t\\t\\t\\t\\tmu.Unlock()\\n\\n\\t\\t\\t\\t\\t// Verify the workflow file was updated\\n\\t\\t\\t\\t\\tupdatedContent, readErr := os.ReadFile(workflowFile)\\n\\t\\t\\t\\t\\tif readErr != nil {\\n\\t\\t\\t\\t\\t\\tt.Errorf(\\\"Failed to read updated workflow file: %v\\\", readErr)\\n\\t\\t\\t\\t\\t} else {\\n\\t\\t\\t\\t\\t\\tupdatedStr := string(updatedContent)\\n\\t\\t\\t\\t\\t\\tif !strings.Contains(updatedStr, \\\"mcp:\\\") {\\n\\t\\t\\t\\t\\t\\t\\tt.Errorf(\\\"Expected MCP configuration to be added to workflow for server %s\\\", serverName)\\n\\t\\t\\t\\t\\t\\t}\\n\\t\\t\\t\\t\\t}\\n\\t\\t\\t\\t}\\n\\t\\t\\tcase <-time.After(timeout):\\n\\t\\t\\t\\tt.Logf(\\\"Warning: Timeout adding server %s after %v\\\", serverName, timeout)\\n\\t\\t\\t\\tmu.Lock()\\n\\t\\t\\t\\tfailureCount++\\n\\t\\t\\t\\tmu.Unlock()\\n\\t\\t\\t}\"}" (Pattern: Generic WARNING messages, Raw log: "arguments": "{\"path\": \"/home/runner/work/gh-aw/gh-aw/pkg/cli/mcp_add_integration_test.go\", \"old_str\": \"\\t\\t\\t...)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
agent-stdio.log
Expired
|
8.1 KB |
sha256:c9f6334c1dec6d32cdd50633b2e04b153fe00cbe8a0614db04eb6d3cc0bd52e5
|
|
|
agent_output.json
Expired
|
2.42 KB |
sha256:807982da4baff2a137c29e31f8546534cc1fef95f48dfcbd846a506d39f2b5ad
|
|
|
agent_outputs
Expired
|
39.9 KB |
sha256:eab6814c4b4bac330667baa77e743f340d18d68e2fe8afdc124d6f32c8faa700
|
|
|
aw.patch
Expired
|
1.27 KB |
sha256:261e04382f190b6c132b4972722f112b3116a51e55f3c46c0c644f48c08c97d8
|
|
|
aw_info.json
Expired
|
494 Bytes |
sha256:e5a14fbfe9da8e2570701f0719d8b758fe6e4939517582062e7e7ca62feb2665
|
|
|
prompt.txt
Expired
|
6.42 KB |
sha256:6863e7b1cb5a68e952d8cd4fe91edd107b022602b0ab30897962f1e7a5ea1659
|
|
|
safe_output.jsonl
Expired
|
2.4 KB |
sha256:5977c8d8713f8161df83bee1f4ed24d1f027bd0e32c4460f6f5ad665474f14a4
|
|
|
threat-detection.log
Expired
|
466 Bytes |
sha256:51cf009b57bd1bd964b0de6aa465cf5c22044d08ae792c8feeaf134a0c6e3ccf
|
|