Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention of JetBrains IDEs in changing AI models #36656

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rakleed
Copy link
Contributor

@rakleed rakleed commented Mar 6, 2025

Why:

Closes: #36305

What's being changed (if available, include any code snippets, screenshots, or gifs):

Add mention of JetBrains IDEs in changing AI models, also add absent text and unify it

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@Copilot Copilot bot review requested due to automatic review settings March 6, 2025 23:03
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
copilot/using-github-copilot/ai-models/changing-the-ai-model-for-copilot-chat.md fpt
ghec
fpt
ghec
copilot/using-github-copilot/ai-models/using-claude-sonnet-in-github-copilot.md fpt
ghec
fpt
ghec
copilot/using-github-copilot/ai-models/using-gemini-flash-in-github-copilot.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds support for JetBrains IDEs in the documentation for changing and using AI models for GitHub Copilot Chat. The changes update headings, add new bullet items for JetBrains IDEs, and refine instruction notes for improved clarity and consistency.

  • Added JetBrains IDEs as a supported client in multiple documentation files.
  • Updated titles and instructional blocks for clarity.
  • Included a new note on multi-model support in a public preview phase.

Reviewed Changes

File Description
content/copilot/using-github-copilot/ai-models/changing-the-ai-model-for-copilot-chat.md Updated headings and instructional notes, including the addition of a note for multi-model support and changes to the dropdown description.
content/copilot/using-github-copilot/ai-models/using-gemini-flash-in-github-copilot.md Added a bullet item for JetBrains IDEs.
content/copilot/using-github-copilot/ai-models/using-claude-sonnet-in-github-copilot.md Added duplicate bullet items for JetBrains IDEs which need consolidation.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

content/copilot/using-github-copilot/ai-models/changing-the-ai-model-for-copilot-chat.md:165

  • [nitpick] The label 'CURRENT-MODEL' may be unclear to users; consider using a more descriptive label or a variable substitution consistent with other sections.
1. In the bottom right of the chat view, select an AI model of your choice from the **CURRENT-MODEL** {% octicon "chevron-down" aria-hidden="true" %} dropdown menu.


To use multi-model {% data variables.product.prodname_copilot_chat_short %}, you must use {% data variables.product.prodname_vs %} 2022 version 17.12 or later. See the [{% data variables.product.prodname_vs %} downloads page](https://visualstudio.microsoft.com/downloads/).
> [!IMPORTANT] To use multi-model {% data variables.product.prodname_copilot_chat_short %}, you must use {% data variables.product.prodname_vs %} 2022 version 17.12 or later. See the [{% data variables.product.prodname_vs %} downloads page](https://visualstudio.microsoft.com/downloads/).
Copy link
Contributor Author

@rakleed rakleed Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I shouldn’t add it, but it seems crucial because the article all about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very sparing with IMPORTANT, so let's leave this change out

@@ -159,6 +162,6 @@ These instructions are for the JetBrains IDEs. For instructions on different cli

1. Click the **{% octicon "copilot" aria-hidden="true" %}** icon in the status bar.
1. In the popup menu, click **Open {% data variables.product.prodname_copilot_chat %}**.
1. In the bottom right of the chat view, select an AI model of your choice from the {% octicon "chevron-down" aria-hidden="true" %} dropdown menu.
1. In the bottom right of the chat view, select an AI model of your choice from the **CURRENT-MODEL** {% octicon "chevron-down" aria-hidden="true" %} dropdown menu.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-03-07 at 02 05 27

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. In the bottom right of the chat view, select an AI model of your choice from the **CURRENT-MODEL** {% octicon "chevron-down" aria-hidden="true" %} dropdown menu.
1. In the bottom right of the chat view, select the **CURRENT-MODEL** {% octicon "chevron-down" aria-hidden="true" %} dropdown menu, then click the AI model of your choice.

This language has changed a little, so let's make it match the other text

@@ -135,11 +135,14 @@ To use multi-model {% data variables.product.prodname_copilot_chat_short %}, you

{% jetbrains %}

> [!NOTE] Multiple model support in {% data variables.product.prodname_copilot_chat_short %} is in {% data variables.release-phases.public_preview %} and is subject to change.
Copy link
Contributor Author

@rakleed rakleed Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it reusable data? It's repeated 4 times on the page.

Although there are a few other sentences that are also repeated, but they're not reusable data, so it's probably worth leaving as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they're not all identical, and this won't always be true, so we can resolve this 👍

@rakleed
Copy link
Contributor Author

rakleed commented Mar 6, 2025

And a side note: I couldn't find any mention of Claude 3.7 Sonnet Thinking, probably need to raise an issue for it.

@@ -22,12 +22,14 @@ redirect_from:
* {% data variables.product.prodname_copilot_chat_short %} in {% data variables.product.prodname_vscode %}
* {% data variables.product.prodname_copilot_chat_short %} in {% data variables.product.prodname_vs %} 2022 version 17.13 or later
* Immersive mode in {% data variables.product.prodname_copilot_chat_short %} in {% data variables.product.github %}
* {% data variables.product.prodname_copilot_chat_short %} in JetBrains IDEs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you have a variable with the product name for JetBrains IDEs? It seems like it's used a lot in the code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's used a lot in the code.

Whilst this is true, we only use variables for our own products 😄

@subatoi subatoi added the waiting for review Issue/PR is waiting for a writer's review label Mar 7, 2025
@subatoi
Copy link
Contributor

subatoi commented Mar 7, 2025

Thanks for raising this, @rakleed! We'll review it as soon as we can

@subatoi subatoi removed the triage Do not begin working on this issue until triaged by the team label Mar 7, 2025
@@ -159,6 +162,6 @@ These instructions are for the JetBrains IDEs. For instructions on different cli

1. Click the **{% octicon "copilot" aria-hidden="true" %}** icon in the status bar.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, GitHub Copilot Chat can be opened via Tool Window Bar on the right with one click.

CleanShot 2025-03-07 at 16 42 48

Should I make it a separate sentence or add to the beginning of the first point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try to have an "opinionated" docs approach, so we stick to one recommended path

Since we don't control the JetBrains user experience, I'd recommend that we stick with one here and leave this out

@github github deleted a comment from mehran-shabani Mar 19, 2025
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @rakleed, and thank you for your patience

We really appreciate you taking the time to submit these changes—I'm happy to approve and merge this, but we just need to make a few style-based edits first. If you'd rather that I take these in-house and credit you as co-committer, rather than you going through them, that's fine, just let me know

Thanks again!

Comment on lines +49 to +51
## Changing the AI model for {% data variables.product.prodname_copilot_chat_short %}

These instructions are for {% data variables.product.prodname_copilot_short %} on the {% data variables.product.github %} website. For {% data variables.product.prodname_vs %} or {% data variables.product.prodname_vscode_shortname %}, click the appropriate tab at the top of this page.
These instructions are for the {% data variables.product.github %}. For instructions on different clients, click the appropriate tab at the top of this page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to make all of these changes here—the product switcher will take care of helping the users understand where they're at. Let's change most of this back, but keep the second sentence:

For instructions on different clients, click the appropriate tab at the top of this page.

Also, I think there might be more places we now need to make this change in, that have been written in since this PR was created.

Comment on lines +89 to +91
## Changing the AI model for {% data variables.product.prodname_copilot_chat_short %}

These instructions are for {% data variables.product.prodname_vscode_shortname %}. For {% data variables.product.prodname_vs %} or for {% data variables.product.prodname_copilot_short %} on the {% data variables.product.github %} website, click the appropriate tab at the top of this page.
These instructions are for the {% data variables.product.prodname_vscode %}. For instructions on different clients, click the appropriate tab at the top of this page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, let's just keep the second sentence:

For instructions on different clients, click the appropriate tab at the top of this page.

@@ -120,9 +120,9 @@ For more information about these models, see:

## Changing the AI model for {% data variables.product.prodname_copilot_chat_short %}

These instructions are for {% data variables.product.prodname_vs %}. For {% data variables.product.prodname_vscode_shortname %} or for {% data variables.product.prodname_copilot_short %} on the {% data variables.product.github %} website, click the appropriate tab at the top of this page.
These instructions are for the {% data variables.product.prodname_vs %}. For instructions on different clients, click the appropriate tab at the top of this page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, let's just keep the second sentence:

For instructions on different clients, click the appropriate tab at the top of this page.

@@ -159,6 +162,6 @@ These instructions are for the JetBrains IDEs. For instructions on different cli

1. Click the **{% octicon "copilot" aria-hidden="true" %}** icon in the status bar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try to have an "opinionated" docs approach, so we stick to one recommended path

Since we don't control the JetBrains user experience, I'd recommend that we stick with one here and leave this out

@@ -135,11 +135,14 @@ To use multi-model {% data variables.product.prodname_copilot_chat_short %}, you

{% jetbrains %}

> [!NOTE] Multiple model support in {% data variables.product.prodname_copilot_chat_short %} is in {% data variables.release-phases.public_preview %} and is subject to change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they're not all identical, and this won't always be true, so we can resolve this 👍


To use multi-model {% data variables.product.prodname_copilot_chat_short %}, you must use {% data variables.product.prodname_vs %} 2022 version 17.12 or later. See the [{% data variables.product.prodname_vs %} downloads page](https://visualstudio.microsoft.com/downloads/).
> [!IMPORTANT] To use multi-model {% data variables.product.prodname_copilot_chat_short %}, you must use {% data variables.product.prodname_vs %} 2022 version 17.12 or later. See the [{% data variables.product.prodname_vs %} downloads page](https://visualstudio.microsoft.com/downloads/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very sparing with IMPORTANT, so let's leave this change out

@@ -22,12 +22,14 @@ redirect_from:
* {% data variables.product.prodname_copilot_chat_short %} in {% data variables.product.prodname_vscode %}
* {% data variables.product.prodname_copilot_chat_short %} in {% data variables.product.prodname_vs %} 2022 version 17.13 or later
* Immersive mode in {% data variables.product.prodname_copilot_chat_short %} in {% data variables.product.github %}
* {% data variables.product.prodname_copilot_chat_short %} in JetBrains IDEs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's used a lot in the code.

Whilst this is true, we only use variables for our own products 😄

@@ -159,6 +162,6 @@ These instructions are for the JetBrains IDEs. For instructions on different cli

1. Click the **{% octicon "copilot" aria-hidden="true" %}** icon in the status bar.
1. In the popup menu, click **Open {% data variables.product.prodname_copilot_chat %}**.
1. In the bottom right of the chat view, select an AI model of your choice from the {% octicon "chevron-down" aria-hidden="true" %} dropdown menu.
1. In the bottom right of the chat view, select an AI model of your choice from the **CURRENT-MODEL** {% octicon "chevron-down" aria-hidden="true" %} dropdown menu.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. In the bottom right of the chat view, select an AI model of your choice from the **CURRENT-MODEL** {% octicon "chevron-down" aria-hidden="true" %} dropdown menu.
1. In the bottom right of the chat view, select the **CURRENT-MODEL** {% octicon "chevron-down" aria-hidden="true" %} dropdown menu, then click the AI model of your choice.

This language has changed a little, so let's make it match the other text

@github github deleted a comment Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Copilot for JetBrains now supports changing AI models in the chat
2 participants