Skip to content

Commit fb0f356

Browse files
test: unskip pending_work_resume; scope inproc-only skips conditionally
The 3 pending_work_resume 'continue pending ... after resume' tests are fixed by the abort-scoping change (stop() no longer aborts external-server sessions), so unskip them. The disconnect-driven capability tests (multi-client, ui_elicitation) and 'should delete session by id' fail only over the in-process transport (host-side auth resolved from process.env is dropped by the harness afterEach before the delete-triggered resume runs), so gate them with it.skipIf(isInProcessTransport) instead of skipping unconditionally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 6ac63b8 commit fb0f356

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

nodejs/test/e2e/client_api.e2e.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import { describe, expect, it } from "vitest";
66
import { approveAll } from "../../src/index.js";
7-
import { createSdkTestContext } from "./harness/sdkTestContext.js";
7+
import { createSdkTestContext, isInProcessTransport } from "./harness/sdkTestContext.js";
88

99
describe("Client session management", async () => {
1010
const { copilotClient: client } = await createSdkTestContext();
@@ -36,7 +36,7 @@ describe("Client session management", async () => {
3636
expect(result).toBeFalsy();
3737
});
3838

39-
it.skip("should delete session by id", async () => {
39+
it.skipIf(isInProcessTransport)("should delete session by id", async () => {
4040
const session = await client.createSession({ onPermissionRequest: approveAll });
4141
const sessionId = session.sessionId;
4242

nodejs/test/e2e/multi-client.e2e.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { describe, expect, it, afterAll } from "vitest";
66
import { z } from "zod";
77
import { CopilotClient, defineTool, approveAll, RuntimeConnection } from "../../src/index.js";
88
import type { SessionEvent } from "../../src/index.js";
9-
import { createSdkTestContext } from "./harness/sdkTestContext";
9+
import { createSdkTestContext, isInProcessTransport } from "./harness/sdkTestContext";
1010

1111
describe("Multi-client broadcast", async () => {
1212
// Use TCP mode so a second client can connect to the same CLI process
@@ -304,7 +304,7 @@ describe("Multi-client broadcast", async () => {
304304
}
305305
);
306306

307-
it.skip("disconnecting client removes its tools", { timeout: 90_000 }, async () => {
307+
it.skipIf(isInProcessTransport)("disconnecting client removes its tools", { timeout: 90_000 }, async () => {
308308
const toolA = defineTool("stable_tool", {
309309
description: "A tool that persists across disconnects",
310310
parameters: z.object({ input: z.string() }),

nodejs/test/e2e/pending_work_resume.e2e.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ describe("Pending work resume", async () => {
180180
return `localhost:${port}`;
181181
}
182182

183-
it.skip(
183+
it(
184184
"should continue pending permission request after resume",
185185
{ timeout: TEST_TIMEOUT_MS },
186186
async () => {
@@ -254,7 +254,7 @@ describe("Pending work resume", async () => {
254254
}
255255
);
256256

257-
it.skip(
257+
it(
258258
"should continue pending external tool request after resume",
259259
{ timeout: TEST_TIMEOUT_MS },
260260
async () => {
@@ -323,7 +323,7 @@ describe("Pending work resume", async () => {
323323
}
324324
);
325325

326-
it.skip(
326+
it(
327327
"should continue parallel pending external tool requests after resume",
328328
{ timeout: TEST_TIMEOUT_MS },
329329
async () => {

nodejs/test/e2e/ui_elicitation.e2e.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import { afterAll, describe, expect, it } from "vitest";
66
import { CopilotClient, approveAll, RuntimeConnection } from "../../src/index.js";
77
import type { SessionEvent } from "../../src/index.js";
8-
import { createSdkTestContext } from "./harness/sdkTestContext.js";
8+
import { createSdkTestContext, isInProcessTransport } from "./harness/sdkTestContext.js";
99

1010
describe("UI Elicitation", async () => {
1111
const { copilotClient: client } = await createSdkTestContext();
@@ -116,7 +116,7 @@ describe("UI Elicitation Multi-Client Capabilities", async () => {
116116
}
117117
);
118118

119-
it.skip(
119+
it.skipIf(isInProcessTransport)(
120120
"capabilities.changed fires when elicitation provider disconnects",
121121
{ timeout: 60_000 },
122122
async () => {

0 commit comments

Comments
 (0)