chore: update all tests, scenarios, and docs to use disconnect()

Migrate all test scenarios, e2e tests, READMEs, and documentation
references from destroy()/Destroy() to disconnect()/Disconnect().

- 90 test scenario files across Go/Python/TypeScript/C#
- 15 Node.js e2e test files
- 8 Python e2e test files
- 3 Go e2e test files
- 1 .NET test file
- READMEs and compatibility docs updated with new API reference
- Agent docs updated with new method names
- Reconnect scenario log messages updated to 'disconnected'

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: patniko

.github/agents/docs-maintenance.agent.md

@@ -344,7 +344,7 @@ cat nodejs/src/types.ts | grep -A 10 "export interface ExportSessionOptions"
 **Must match:**
 - `CopilotClient` constructor options: `cliPath`, `cliUrl`, `useStdio`, `port`, `logLevel`, `autoStart`, `autoRestart`, `env`, `githubToken`, `useLoggedInUser`
 - `createSession()` config: `model`, `tools`, `hooks`, `systemMessage`, `mcpServers`, `availableTools`, `excludedTools`, `streaming`, `reasoningEffort`, `provider`, `infiniteSessions`, `customAgents`, `workingDirectory`
-- `CopilotSession` methods: `send()`, `sendAndWait()`, `getMessages()`, `destroy()`, `abort()`, `on()`, `once()`, `off()`
+- `CopilotSession` methods: `send()`, `sendAndWait()`, `getMessages()`, `disconnect()`, `abort()`, `on()`, `once()`, `off()`
 - Hook names: `onPreToolUse`, `onPostToolUse`, `onUserPromptSubmitted`, `onSessionStart`, `onSessionEnd`, `onErrorOccurred`
 
 #### Python Validation
@@ -362,7 +362,7 @@ cat python/copilot/types.py | grep -A 15 "class SessionHooks"
 **Must match (snake_case):**
 - `CopilotClient` options: `cli_path`, `cli_url`, `use_stdio`, `port`, `log_level`, `auto_start`, `auto_restart`, `env`, `github_token`, `use_logged_in_user`
 - `create_session()` config keys: `model`, `tools`, `hooks`, `system_message`, `mcp_servers`, `available_tools`, `excluded_tools`, `streaming`, `reasoning_effort`, `provider`, `infinite_sessions`, `custom_agents`, `working_directory`
-- `CopilotSession` methods: `send()`, `send_and_wait()`, `get_messages()`, `destroy()`, `abort()`, `export_session()`
+- `CopilotSession` methods: `send()`, `send_and_wait()`, `get_messages()`, `disconnect()`, `abort()`, `export_session()`
 - Hook names: `on_pre_tool_use`, `on_post_tool_use`, `on_user_prompt_submitted`, `on_session_start`, `on_session_end`, `on_error_occurred`
 
 #### Go Validation
@@ -380,7 +380,7 @@ cat go/types.go | grep -A 15 "type SessionHooks struct"
 **Must match (PascalCase for exported):**
 - `ClientOptions` fields: `CLIPath`, `CLIUrl`, `UseStdio`, `Port`, `LogLevel`, `AutoStart`, `AutoRestart`, `Env`, `GithubToken`, `UseLoggedInUser`
 - `SessionConfig` fields: `Model`, `Tools`, `Hooks`, `SystemMessage`, `MCPServers`, `AvailableTools`, `ExcludedTools`, `Streaming`, `ReasoningEffort`, `Provider`, `InfiniteSessions`, `CustomAgents`, `WorkingDirectory`
-- `Session` methods: `Send()`, `SendAndWait()`, `GetMessages()`, `Destroy()`, `Abort()`, `ExportSession()`
+- `Session` methods: `Send()`, `SendAndWait()`, `GetMessages()`, `Disconnect()`, `Abort()`, `ExportSession()`
 - Hook fields: `OnPreToolUse`, `OnPostToolUse`, `OnUserPromptSubmitted`, `OnSessionStart`, `OnSessionEnd`, `OnErrorOccurred`
 
 #### .NET Validation

docs/compatibility.md

@@ -15,7 +15,8 @@ The Copilot SDK communicates with the CLI via JSON-RPC protocol. Features must b
 | **Session Management** | | |
 | Create session | `createSession()` | Full config support |
 | Resume session | `resumeSession()` | With infinite session workspaces |
-| Destroy session | `destroy()` | Clean up resources |
+| Disconnect session | `disconnect()` | Release in-memory resources |
+| Destroy session *(deprecated)* | `destroy()` | Use `disconnect()` instead |
 | Delete session | `deleteSession()` | Remove from storage |
 | List sessions | `listSessions()` | All stored sessions |
 | Get last session | `getLastSessionId()` | For quick resume |

docs/guides/setup/scaling.md

@@ -412,7 +412,7 @@ class SessionManager {
     private async evictOldestSession(): Promise<void> {
         const [oldestId] = this.activeSessions.keys();
         const session = this.activeSessions.get(oldestId)!;
-        // Session state is persisted automatically — safe to destroy
+        // Session state is persisted automatically — safe to disconnect
         await session.disconnect();
         this.activeSessions.delete(oldestId);
     }

dotnet/test/SessionTests.cs

@@ -13,7 +13,7 @@ namespace GitHub.Copilot.SDK.Test;
 public class SessionTests(E2ETestFixture fixture, ITestOutputHelper output) : E2ETestBase(fixture, "session", output)
 {
     [Fact]
-    public async Task ShouldCreateAndDestroySessions()
+    public async Task ShouldCreateAndDisconnectSessions()
     {
         var session = await CreateSessionAsync(new SessionConfig { Model = "fake-test-model" });
 

go/README.md

@@ -168,7 +168,8 @@ Event types: `SessionLifecycleCreated`, `SessionLifecycleDeleted`, `SessionLifec
 - `On(handler SessionEventHandler) func()` - Subscribe to events (returns unsubscribe function)
 - `Abort(ctx context.Context) error` - Abort the currently processing message
 - `GetMessages(ctx context.Context) ([]SessionEvent, error)` - Get message history
-- `Destroy() error` - Destroy the session
+- `Disconnect() error` - Disconnect the session (releases in-memory resources, preserves disk state)
+- `Destroy() error` - *(Deprecated)* Use `Disconnect()` instead
 
 ### Helper Functions
 

go/internal/e2e/mcp_and_agents_test.go

@@ -55,7 +55,7 @@ func TestMCPServers(t *testing.T) {
 			t.Errorf("Expected message to contain '4', got: %v", message.Data.Content)
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 
 	t.Run("accept MCP server config on resume", func(t *testing.T) {
@@ -104,7 +104,7 @@ func TestMCPServers(t *testing.T) {
 			t.Errorf("Expected message to contain '6', got: %v", message.Data.Content)
 		}
 
-		session2.Destroy()
+		session2.Disconnect()
 	})
 
 	t.Run("should pass literal env values to MCP server subprocess", func(t *testing.T) {
@@ -150,7 +150,7 @@ func TestMCPServers(t *testing.T) {
 			t.Errorf("Expected message to contain 'hunter2', got: %v", message.Data.Content)
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 
 	t.Run("handle multiple MCP servers", func(t *testing.T) {
@@ -183,7 +183,7 @@ func TestMCPServers(t *testing.T) {
 			t.Error("Expected non-empty session ID")
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 }
 
@@ -235,7 +235,7 @@ func TestCustomAgents(t *testing.T) {
 			t.Errorf("Expected message to contain '10', got: %v", message.Data.Content)
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 
 	t.Run("accept custom agent config on resume", func(t *testing.T) {
@@ -284,7 +284,7 @@ func TestCustomAgents(t *testing.T) {
 			t.Errorf("Expected message to contain '12', got: %v", message.Data.Content)
 		}
 
-		session2.Destroy()
+		session2.Disconnect()
 	})
 
 	t.Run("handle custom agent with tools", func(t *testing.T) {
@@ -314,7 +314,7 @@ func TestCustomAgents(t *testing.T) {
 			t.Error("Expected non-empty session ID")
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 
 	t.Run("handle custom agent with MCP servers", func(t *testing.T) {
@@ -349,7 +349,7 @@ func TestCustomAgents(t *testing.T) {
 			t.Error("Expected non-empty session ID")
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 
 	t.Run("handle multiple custom agents", func(t *testing.T) {
@@ -386,7 +386,7 @@ func TestCustomAgents(t *testing.T) {
 			t.Error("Expected non-empty session ID")
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 }
 
@@ -445,6 +445,6 @@ func TestCombinedConfiguration(t *testing.T) {
 			t.Errorf("Expected message to contain '14', got: %v", message.Data.Content)
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 }

go/internal/e2e/session_test.go

@@ -15,7 +15,7 @@ func TestSession(t *testing.T) {
 	client := ctx.NewClient()
 	t.Cleanup(func() { client.ForceStop() })
 
-	t.Run("should create and destroy sessions", func(t *testing.T) {
+	t.Run("should create and disconnect sessions", func(t *testing.T) {
 		ctx.ConfigureForTest(t)
 
 		session, err := client.CreateSession(t.Context(), &copilot.SessionConfig{OnPermissionRequest: copilot.PermissionHandler.ApproveAll, Model: "fake-test-model"})
@@ -45,13 +45,13 @@ func TestSession(t *testing.T) {
 			t.Errorf("Expected selectedModel to be 'fake-test-model', got %v", messages[0].Data.SelectedModel)
 		}
 
-		if err := session.Destroy(); err != nil {
-			t.Fatalf("Failed to destroy session: %v", err)
+		if err := session.Disconnect(); err != nil {
+			t.Fatalf("Failed to disconnect session: %v", err)
 		}
 
 		_, err = session.GetMessages(t.Context())
 		if err == nil || !strings.Contains(err.Error(), "not found") {
-			t.Errorf("Expected GetMessages to fail with 'not found' after destroy, got %v", err)
+			t.Errorf("Expected GetMessages to fail with 'not found' after disconnect, got %v", err)
 		}
 	})
 

go/internal/e2e/skills_test.go

@@ -76,7 +76,7 @@ func TestSkills(t *testing.T) {
 			t.Errorf("Expected message to contain skill marker '%s', got: %v", skillMarker, message.Data.Content)
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 
 	t.Run("should not apply skill when disabled via disabledSkills", func(t *testing.T) {
@@ -105,7 +105,7 @@ func TestSkills(t *testing.T) {
 			t.Errorf("Expected message to NOT contain skill marker '%s' when disabled, got: %v", skillMarker, *message.Data.Content)
 		}
 
-		session.Destroy()
+		session.Disconnect()
 	})
 
 	t.Run("should apply skill on session resume with skillDirectories", func(t *testing.T) {
@@ -154,6 +154,6 @@ func TestSkills(t *testing.T) {
 			t.Errorf("Expected message to contain skill marker '%s' after resume, got: %v", skillMarker, message2.Data.Content)
 		}
 
-		session2.Destroy()
+		session2.Disconnect()
 	})
 }

nodejs/README.md

@@ -265,9 +265,13 @@ Abort the currently processing message in this session.
 
 Get all events/messages from this session.
 
-##### `destroy(): Promise<void>`
+##### `disconnect(): Promise<void>`
 
-Destroy the session and free resources.
+Disconnect the session and free resources. Session data on disk is preserved for later resumption.
+
+##### `destroy(): Promise<void>` *(deprecated)*
+
+Deprecated — use `disconnect()` instead.
 
 ---
 

nodejs/test/e2e/agent_and_compact_rpc.test.ts

@@ -40,7 +40,7 @@ describe("Agent Selection RPC", async () => {
         expect(result.agents[0].description).toBe("A test agent");
         expect(result.agents[1].name).toBe("another-agent");
 
-        await session.destroy();
+        await session.disconnect();
     });
 
     it("should return null when no agent is selected", async () => {
@@ -61,7 +61,7 @@ describe("Agent Selection RPC", async () => {
         const result = await session.rpc.agent.getCurrent();
         expect(result.agent).toBeNull();
 
-        await session.destroy();
+        await session.disconnect();
     });
 
     it("should select and get current agent", async () => {
@@ -90,7 +90,7 @@ describe("Agent Selection RPC", async () => {
         expect(currentResult.agent).not.toBeNull();
         expect(currentResult.agent!.name).toBe("test-agent");
 
-        await session.destroy();
+        await session.disconnect();
     });
 
     it("should deselect current agent", async () => {
@@ -116,7 +116,7 @@ describe("Agent Selection RPC", async () => {
         const currentResult = await session.rpc.agent.getCurrent();
         expect(currentResult.agent).toBeNull();
 
-        await session.destroy();
+        await session.disconnect();
     });
 
     it("should return empty list when no custom agents configured", async () => {
@@ -125,7 +125,7 @@ describe("Agent Selection RPC", async () => {
         const result = await session.rpc.agent.list();
         expect(result.agents).toEqual([]);
 
-        await session.destroy();
+        await session.disconnect();
     });
 });
 
@@ -144,6 +144,6 @@ describe("Session Compact RPC", async () => {
         expect(typeof result.tokensRemoved).toBe("number");
         expect(typeof result.messagesRemoved).toBe("number");
 
-        await session.destroy();
+        await session.disconnect();
     }, 60000);
 });