Merge remote-tracking branch 'origin/main' into belaltaher8/tool-meta-passthrough

# Conflicts:
#	python/test_client.py

Author: belaltaher8

.github/lsp.json

@@ -21,24 +21,6 @@
         ".go": "go"
       },
       "rootUri": "go"
-    },
-    "rust-analyzer": {
-      "command": "rust-analyzer",
-      "fileExtensions": {
-        ".rs": "rust"
-      },
-      "initializationOptions": {
-        "cargo": {
-          "buildScripts": {
-            "enable": true
-          },
-          "allFeatures": true
-        },
-        "checkOnSave": true,
-        "check": {
-          "command": "clippy"
-        }
-      }
     }
   }
 }

.github/workflows/java-publish-maven.yml

@@ -22,6 +22,34 @@ on:
         type: boolean
         required: false
         default: false
+  workflow_call:
+    inputs:
+      releaseVersion:
+        description: "Release version (e.g., 1.0.0). If empty, derives from pom.xml by removing -SNAPSHOT"
+        required: false
+        type: string
+      developmentVersion:
+        description: "Next development version (e.g., 1.0.1-SNAPSHOT). If empty, increments patch version"
+        required: false
+        type: string
+      prerelease:
+        description: "Is this a prerelease?"
+        type: boolean
+        required: false
+        default: false
+    secrets:
+      JAVA_RELEASE_TOKEN:
+        required: true
+      JAVA_RELEASE_GITHUB_TOKEN:
+        required: true
+      JAVA_MAVEN_CENTRAL_USERNAME:
+        required: true
+      JAVA_MAVEN_CENTRAL_PASSWORD:
+        required: true
+      JAVA_GPG_SECRET_KEY:
+        required: true
+      JAVA_GPG_PASSPHRASE:
+        required: true
 
 permissions:
   contents: write
@@ -144,10 +172,10 @@ jobs:
               exit 1
             fi
           else
-            # Split version: supports "0.1.32", "0.1.32-java.0", and "0.1.32-java-preview.0" formats
+            # Split version: supports "0.1.32", "0.1.32-preview.0", "0.1.32-java.0", and "0.1.32-java-preview.0" formats
             # Validate RELEASE_VERSION format explicitly to provide clear errors
-            if ! echo "$RELEASE_VERSION" | grep -qE '^[0-9]+\.[0-9]+\.[0-9]+(-(beta-)?java(-preview)?\.[0-9]+)?$'; then
-              echo "Error: RELEASE_VERSION '$RELEASE_VERSION' is invalid. Expected format: M.M.P, M.M.P-java.N, M.M.P-java-preview.N, M.M.P-beta-java.N, or M.M.P-beta-java-preview.N (e.g., 1.2.3, 1.2.3-java.0, 1.2.3-java-preview.0, 1.2.3-beta-java.0, or 1.2.3-beta-java-preview.0)." >&2
+            if ! echo "$RELEASE_VERSION" | grep -qE '^[0-9]+\.[0-9]+\.[0-9]+(-(preview|(beta-)?java(-preview)?)\.[0-9]+)?$'; then
+              echo "Error: RELEASE_VERSION '$RELEASE_VERSION' is invalid. Expected format: M.M.P, M.M.P-preview.N, M.M.P-java.N, M.M.P-java-preview.N, M.M.P-beta-java.N, or M.M.P-beta-java-preview.N (e.g., 1.2.3, 1.2.3-preview.0, 1.2.3-java.0, 1.2.3-java-preview.0, 1.2.3-beta-java.0, or 1.2.3-beta-java-preview.0)." >&2
               exit 1
             fi
             # Extract the base M.M.P portion (before any qualifier)

.github/workflows/nodejs-sdk-tests.yml

@@ -31,14 +31,15 @@ permissions:
 
 jobs:
   test:
-    name: "Node.js SDK Tests"
+    name: "Node.js SDK Tests (${{ matrix.os }}, ${{ matrix.transport }})"
     if: github.event.repository.fork == false
     env:
       POWERSHELL_UPDATECHECK: Off
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
+        transport: ["default", "inprocess"]
     runs-on: ${{ matrix.os }}
     defaults:
       run:
@@ -75,6 +76,11 @@ jobs:
         if: runner.os == 'Windows'
         run: pwsh.exe -Command "Write-Host 'PowerShell ready'"
 
+      - name: Select inprocess transport
+        if: matrix.transport == 'inprocess'
+        run: |
+          echo "COPILOT_SDK_DEFAULT_CONNECTION=inprocess" >> "$GITHUB_ENV"
+
       - name: Run Node.js SDK tests
         env:
           COPILOT_HMAC_KEY: ${{ secrets.COPILOT_DEVELOPER_CLI_INTEGRATION_HMAC_KEY }}

.github/workflows/publish.yml

@@ -171,13 +171,17 @@ jobs:
       - name: Set version
         run: sed -i -E 's/^version = ".*"$/version = "${{ needs.version.outputs.version }}"/' Cargo.toml
       - name: Snapshot CLI version + hashes for build.rs
-        run: bash scripts/snapshot-bundled-cli-version.sh
-      - name: Verify cli-version.txt exists
         run: |
-          if [[ ! -f cli-version.txt ]]; then
-            echo "::error::cli-version.txt was not generated. The Snapshot step must run before packaging."
-            exit 1
-          fi
+          bash scripts/snapshot-bundled-cli-version.sh
+          bash scripts/snapshot-bundled-in-process-version.sh
+      - name: Verify CLI version snapshots exist
+        run: |
+          for snapshot in cli-version.txt cli-version-in-process.txt; do
+            if [[ ! -f "${snapshot}" ]]; then
+              echo "::error::${snapshot} was not generated. The Snapshot step must run before packaging."
+              exit 1
+            fi
+          done
       - name: Package (dry run)
         run: cargo publish --dry-run --allow-dirty
       - name: Upload artifact
@@ -229,10 +233,28 @@ jobs:
         with:
           packages-dir: python/dist/
 
+  publish-java:
+    name: Publish Java SDK
+    if: github.event.inputs.dist-tag != 'unstable' && github.ref == 'refs/heads/main'
+    needs: version
+    uses: ./.github/workflows/java-publish-maven.yml
+    with:
+      releaseVersion: ${{ needs.version.outputs.version }}
+      prerelease: ${{ github.event.inputs.dist-tag == 'prerelease' }}
+    secrets: inherit
+
   github-release:
     name: Create GitHub Release
-    needs: [version, publish-nodejs, publish-dotnet, publish-python, publish-rust]
-    if: github.ref == 'refs/heads/main' && github.event.inputs.dist-tag != 'unstable'
+    needs: [version, publish-nodejs, publish-dotnet, publish-python, publish-rust, publish-java]
+    if: |
+      always() &&
+      github.ref == 'refs/heads/main' &&
+      github.event.inputs.dist-tag != 'unstable' &&
+      needs.version.result == 'success' &&
+      needs.publish-nodejs.result == 'success' &&
+      needs.publish-dotnet.result == 'success' &&
+      needs.publish-python.result == 'success' &&
+      needs.publish-rust.result == 'success'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6.0.2

.github/workflows/rust-sdk-tests.yml

@@ -29,7 +29,7 @@ permissions:
 
 jobs:
   test:
-    name: "Rust SDK Tests"
+    name: "Rust SDK Tests (${{ matrix.os }}, default)"
     if: github.event.repository.fork == false
     env:
       POWERSHELL_UPDATECHECK: Off
@@ -84,7 +84,7 @@ jobs:
       # Share the bundled-CLI archive cache with the `bundle` job: build.rs
       # now downloads in both modes (embed for `bundle`, extract-to-cache
       # for this `test` job's `--no-default-features` build).
-      - name: Cache bundled CLI tarball
+      - name: Cache bundled CLI archives
         uses: actions/cache@v4
         with:
           path: ./rust/.bundled-cli-cache
@@ -98,7 +98,7 @@ jobs:
         if: runner.os == 'Linux'
         env:
           BUNDLED_CLI_CACHE_DIR: ${{ github.workspace }}/rust/.bundled-cli-cache
-        run: cargo clippy --all-targets --features test-support -- --no-deps -D warnings -D clippy::unwrap_used -D clippy::disallowed_macros -D clippy::await_holding_invalid_type
+        run: cargo clippy --all-targets --features test-support,bundled-in-process -- --no-deps -D warnings -D clippy::unwrap_used -D clippy::disallowed_macros -D clippy::await_holding_invalid_type
 
       - name: cargo doc
         if: runner.os == 'Linux'
@@ -129,14 +129,92 @@ jobs:
         # The dedicated `bundle` job below exercises the embed pipeline.
         run: cargo test --no-default-features --features test-support -- --test-threads=4 --nocapture
 
+  # Exercises the in-process FFI transport (`Transport::InProcess`, the Rust
+  # analogue of the .NET `RuntimeConnection.ForInProcess()`), mirroring the
+  # `inprocess` transport cell in dotnet-sdk-tests.yml. Sets
+  # COPILOT_SDK_DEFAULT_CONNECTION=inprocess so the client hosts the runtime
+  # cdylib in-process instead of spawning a stdio child, then runs the whole
+  # E2E suite over the in-process transport. The suite runs serially in-process
+  # (the harness forces concurrency to 1) because it mirrors each test's
+  # environment onto the shared process environment the in-process worker inherits.
+  # Runs the whole E2E suite over the in-process transport on supported hosts.
+  test-inprocess:
+    name: "Rust SDK Tests (${{ matrix.os }}, inprocess)"
+    if: github.event.repository.fork == false
+    env:
+      CARGO_TERM_COLOR: always
+      RUST_BACKTRACE: 1
+    strategy:
+      fail-fast: false
+      matrix:
+        # TODO: Re-enable Windows after fixing the napi-oop peer shutdown crash.
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
+    defaults:
+      run:
+        shell: bash
+        working-directory: ./rust
+    steps:
+      - uses: actions/checkout@v6.0.2
+
+      - uses: ./.github/actions/setup-copilot
+        id: setup-copilot
+
+      - name: Install Rust toolchain
+        uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
+        with:
+          toolchain: "1.94.0"
+
+      - uses: Swatinem/rust-cache@42dc69e1aa15d09112580998cf2ef0119e2e91ae # v2
+        with:
+          workspaces: "rust"
+          prefix-key: v1-rust-no-bin
+          cache-bin: false
+
+      - name: Read pinned @github/copilot CLI version
+        id: cli-version
+        working-directory: ./nodejs
+        run: |
+          version=$(node -p "require('./package-lock.json').packages['node_modules/@github/copilot'].version")
+          echo "version=$version" >> "$GITHUB_OUTPUT"
+          echo "Pinned CLI version: $version"
+
+      - name: Cache bundled CLI archives
+        uses: actions/cache@v4
+        with:
+          path: ./rust/.bundled-cli-cache
+          key: bundled-cli-${{ matrix.os }}-${{ steps.cli-version.outputs.version }}
+
+      - name: Install test harness dependencies
+        working-directory: ./test/harness
+        run: npm ci --ignore-scripts
+
+      - name: Warm up PowerShell
+        if: runner.os == 'Windows'
+        run: pwsh.exe -Command "Write-Host 'PowerShell ready'"
+
+      - name: Select in-process transport
+        run: echo "COPILOT_SDK_DEFAULT_CONNECTION=inprocess" >> "$GITHUB_ENV"
+
+      - name: cargo test (in-process transport, full E2E suite)
+        timeout-minutes: 60
+        env:
+          COPILOT_HMAC_KEY: ${{ secrets.COPILOT_DEVELOPER_CLI_INTEGRATION_HMAC_KEY }}
+          COPILOT_CLI_PATH: ${{ steps.setup-copilot.outputs.cli-path }}
+          BUNDLED_CLI_CACHE_DIR: ${{ github.workspace }}/rust/.bundled-cli-cache
+        # The harness forces serial execution in-process (both the async semaphore and
+        # libtest via --test-threads=1) because it mirrors each test's environment onto
+        # the shared process environment, so RUST_E2E_CONCURRENCY is not set here.
+        run: cargo test --no-default-features --features test-support,bundled-in-process --test e2e -- --test-threads=1 --nocapture
+
   # Validates the bundled-CLI build path on all three supported
   # platforms. While the regular `cargo test` job above also exercises
   # build.rs (bundling is on by default now), this matrix job is the
   # dedicated cross-platform smoke test for the download / verify /
   # extract / embed pipeline. Catches regressions before they ship to
   # crates.io and before bundling consumers hit them downstream.
   bundle:
-    name: "Rust SDK Bundled CLI Build"
+    name: "Rust SDK Bundled CLI Build (${{ matrix.os }})"
     if: github.event.repository.fork == false
     env:
       CARGO_TERM_COLOR: always
@@ -180,13 +258,15 @@ jobs:
       # ~130 MB on every CI invocation. Keyed by OS + CLI version so old
       # archives drop out when the pinned version bumps, keeping the
       # cache bounded.
-      - name: Cache bundled CLI tarball
+      - name: Cache bundled CLI archives
         uses: actions/cache@v4
         with:
           path: ./rust/.bundled-cli-cache
           key: bundled-cli-${{ matrix.os }}-${{ steps.cli-version.outputs.version }}
 
-      - name: cargo build (bundled-cli is the default feature)
+      - name: Test bundled CLI build paths
         env:
           BUNDLED_CLI_CACHE_DIR: ${{ github.workspace }}/rust/.bundled-cli-cache
-        run: cargo build
+        run: |
+          cargo build
+          cargo test --features bundled-in-process --lib embedded_archive_contains_only_expected_files