Skip to content

Commit a21cda7

Browse files
committed
Clarify session event type export test
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 18ae619 commit a21cda7

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

nodejs/test/session-event-types.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
* payload types lived in `generated/session-events.ts` and could only be
99
* reached via a deep import (`@github/copilot-sdk/dist/generated/...`).
1010
*
11-
* Most of this file exercises the *type* surface — if these imports type-check
12-
* the public API exposes the types. A small set of runtime assertions
13-
* additionally proves that a concrete `ToolExecutionStartData` value (the
14-
* exact type called out in the issue) round-trips through the exports.
11+
* Most of this file exercises the *type* surface — if these type-only imports
12+
* compile, the public API exposes the types. The runtime assertions below only
13+
* validate representative object shapes for those annotations; they do not
14+
* prove that type-only exports exist at runtime.
1515
*/
1616

1717
import { describe, expect, it } from "vitest";
@@ -83,9 +83,9 @@ const _assistantMessageEventAlignmentCheck: _AssistantMessageEventStaysAlignedWi
8383

8484
describe("Session event type exports (#1156)", () => {
8585
it("exposes the headline ToolExecutionStartData type with a usable shape", () => {
86-
// This is the specific type called out in issue #1156. Build a real
87-
// value through the public re-export so we exercise both the type
88-
// surface and the runtime shape consumers would actually use.
86+
// This is the specific type called out in issue #1156. The annotation
87+
// is the compile-time API-surface check; these assertions only validate
88+
// the representative runtime object shape a consumer would use.
8989
const data: ToolExecutionStartData = {
9090
toolCallId: "call-1",
9191
toolName: "shell",

0 commit comments

Comments
 (0)