Fix Phase I/E/L test failures surfaced by CI

- commands/multi-client/ui_elicitation: shorthand
  'copilotClientOptions: { tcpConnectionToken }' wasn't matched by the
  earlier batch rewrite, so client1 was still spawned in stdio mode
  while client2 tried to connect by URI. Switch the harness call to
  TCP + RuntimeConnection.forTcp({ connectionToken: tcpConnectionToken }).
- session_fs.e2e.test.ts: add the missing RuntimeConnection import.
- hooks_extended.e2e.test.ts: SessionStart and UserPromptSubmitted
  timestamp assertions still used toBeGreaterThan(0) but
  BaseHookInput.timestamp is now Date. Switch to toBeInstanceOf(Date).
- client.test.ts: delete the two obsolete 'allows *Session without
  onPermissionRequest' unit tests. They asserted on the 'Client not
  connected' error that only occurred when autoStart was false; with
  Phase C removing autoStart, the client now auto-starts on the first
  session call and those tests would need a real spawned runtime.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

nodejs/test/client.test.ts

@@ -7,18 +7,6 @@ import { defaultJoinSessionPermissionHandler } from "../src/types.js";
 // This file is for unit tests. Where relevant, prefer to add e2e tests in e2e/*.test.ts instead
 
 describe("CopilotClient", () => {
-    it("allows createSession without onPermissionRequest", async () => {
-        const client = new CopilotClient({});
-
-        await expect(client.createSession({})).rejects.toThrow(/Client not connected/);
-    });
-
-    it("allows resumeSession without onPermissionRequest", async () => {
-        const client = new CopilotClient({});
-
-        await expect(client.resumeSession("session-1", {})).rejects.toThrow(/Client not connected/);
-    });
-
     it("does not respond to v3 permission requests when handler returns no-result", async () => {
         const session = new CopilotSession("session-1", {} as any);
         session.registerPermissionHandler(() => ({ kind: "no-result" }));

nodejs/test/e2e/commands.e2e.test.ts

@@ -11,7 +11,10 @@ describe("Commands", async () => {
     // Use TCP mode so a second client can connect to the same CLI process
     const tcpConnectionToken = "commands-test-token";
     const ctx = await createSdkTestContext({
-        copilotClientOptions: { tcpConnectionToken },
+        useStdio: false,
+        copilotClientOptions: {
+            connection: RuntimeConnection.forTcp({ connectionToken: tcpConnectionToken }),
+        },
     });
     const client1 = ctx.copilotClient;
 

nodejs/test/e2e/hooks_extended.e2e.test.ts

@@ -37,7 +37,7 @@ describe("Extended session hooks", async () => {
 
         expect(sessionStartInputs.length).toBeGreaterThan(0);
         expect(sessionStartInputs[0].source).toBe("new");
-        expect(sessionStartInputs[0].timestamp).toBeGreaterThan(0);
+        expect(sessionStartInputs[0].timestamp).toBeInstanceOf(Date);
         expect(sessionStartInputs[0].cwd).toBeDefined();
 
         await session.disconnect();
@@ -62,7 +62,7 @@ describe("Extended session hooks", async () => {
 
         expect(userPromptInputs.length).toBeGreaterThan(0);
         expect(userPromptInputs[0].prompt).toContain("Say hello");
-        expect(userPromptInputs[0].timestamp).toBeGreaterThan(0);
+        expect(userPromptInputs[0].timestamp).toBeInstanceOf(Date);
         expect(userPromptInputs[0].cwd).toBeDefined();
 
         await session.disconnect();

nodejs/test/e2e/multi-client.e2e.test.ts

@@ -12,7 +12,10 @@ describe("Multi-client broadcast", async () => {
     // Use TCP mode so a second client can connect to the same CLI process
     const tcpConnectionToken = "multi-client-test-token";
     const ctx = await createSdkTestContext({
-        copilotClientOptions: { tcpConnectionToken },
+        useStdio: false,
+        copilotClientOptions: {
+            connection: RuntimeConnection.forTcp({ connectionToken: tcpConnectionToken }),
+        },
     });
     const client1 = ctx.copilotClient;
 

nodejs/test/e2e/session_fs.e2e.test.ts

@@ -9,7 +9,7 @@ import { tmpdir } from "os";
 import { join } from "path";
 import { describe, expect, it, onTestFinished } from "vitest";
 import { CopilotClient } from "../../src/client.js";
-import { createSessionFsAdapter } from "../../src/index.js";
+import { createSessionFsAdapter, RuntimeConnection } from "../../src/index.js";
 import type { SessionFsReaddirWithTypesEntry } from "../../src/generated/rpc.js";
 import {
     approveAll,

nodejs/test/e2e/ui_elicitation.e2e.test.ts

@@ -55,7 +55,10 @@ describe("UI Elicitation Multi-Client Capabilities", async () => {
     // Use TCP mode so a second client can connect to the same CLI process
     const tcpConnectionToken = "ui-elicitation-test-token";
     const ctx = await createSdkTestContext({
-        copilotClientOptions: { tcpConnectionToken },
+        useStdio: false,
+        copilotClientOptions: {
+            connection: RuntimeConnection.forTcp({ connectionToken: tcpConnectionToken }),
+        },
     });
     const client1 = ctx.copilotClient;