Skip to content

Commit 5ca48b1

Browse files
brettcannonCopilot
andauthored
Use dependency groups for Python dev deps (#2038)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0430f7db-6da1-47a9-9a35-fec3f1bbc17e
1 parent 5cd5710 commit 5ca48b1

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/copilot-instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
- Format all: `just format` | Lint all: `just lint` | Test all: `just test`
2525
- Per-language:
2626
- Node: `cd nodejs && npm ci``npm test` (Vitest), `npm run generate:session-types` to regenerate session-event types
27-
- Python: `cd python && uv pip install -e ".[dev]"``uv run pytest` (E2E tests use the test harness)
27+
- Python: `cd python && uv pip install -e . --group dev``uv run pytest` (E2E tests use the test harness)
2828
- Go: `cd go && go test ./...`
2929
- .NET: `cd dotnet && dotnet test test/GitHub.Copilot.SDK.Test.csproj`
3030
- **.NET testing note:** Never add `InternalsVisibleTo` to any project file when writing tests. Tests must only access public APIs.

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ This is a multi-language SDK repository. Install the tools for the SDK(s) you pl
5050

5151
1. Install [Python 3.8+](https://www.python.org/downloads/)
5252
1. Install [uv](https://github.com/astral-sh/uv)
53-
1. Install dependencies: `cd python && uv pip install -e ".[dev]"`
53+
1. Install dependencies: `cd python && uv pip install -e . --group dev`
5454

5555
### Go SDK
5656

justfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ install-go: install-nodejs install-test-harness
109109
# Install Python dependencies and prerequisites for tests
110110
install-python: install-nodejs install-test-harness
111111
@echo "=== Installing Python dependencies ==="
112-
@cd python && uv pip install -e ".[dev]"
112+
@cd python && uv pip install -e . --group dev
113113

114114
# Install .NET dependencies and prerequisites for tests
115115
install-dotnet: install-nodejs install-test-harness

python/pyproject.toml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ Homepage = "https://github.com/github/copilot-sdk"
3535
Repository = "https://github.com/github/copilot-sdk"
3636

3737
[project.optional-dependencies]
38+
telemetry = [
39+
"opentelemetry-api>=1.0.0",
40+
]
41+
42+
[dependency-groups]
3843
dev = [
3944
"ruff>=0.1.0",
4045
"ty>=0.0.2,<0.0.25",
@@ -44,9 +49,6 @@ dev = [
4449
"websockets>=12.0",
4550
"opentelemetry-sdk>=1.0.0",
4651
]
47-
telemetry = [
48-
"opentelemetry-api>=1.0.0",
49-
]
5052

5153
[tool.setuptools.packages.find]
5254
where = ["."]

0 commit comments

Comments
 (0)