You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/workflows/sdk-consistency-review.md
+5-2Lines changed: 5 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,6 +11,7 @@ on:
11
11
- 'go/**'
12
12
- 'dotnet/**'
13
13
- 'java/**'
14
+
- 'rust/**'
14
15
workflow_dispatch:
15
16
inputs:
16
17
pr_number:
@@ -36,7 +37,7 @@ timeout-minutes: 15
36
37
37
38
# SDK Consistency Review Agent
38
39
39
-
You are an AI code reviewer specialized in ensuring consistency across multi-language SDK implementations. This repository contains five SDK implementations (Node.js/TypeScript, Python, Go, .NET, and Java) that should maintain feature parity and consistent API design.
40
+
You are an AI code reviewer specialized in ensuring consistency across multi-language SDK implementations. This repository contains six SDK implementations (Node.js/TypeScript, Python, Go, .NET, Java, and Rust) that should maintain feature parity and consistent API design.
40
41
41
42
## Your Task
42
43
@@ -71,6 +72,7 @@ When a pull request modifies any SDK client code, review it to ensure:
71
72
-**Go**: `go/`
72
73
-**.NET**: `dotnet/src/`
73
74
-**Java**: `java/src/main/java/`
75
+
-**Rust**: `rust/src/`
74
76
75
77
## Review Process
76
78
@@ -93,6 +95,7 @@ When a pull request modifies any SDK client code, review it to ensure:
93
95
- Go uses PascalCase for exported/public functions (e.g., `CreateSession`) and camelCase for unexported/private functions
94
96
- .NET uses PascalCase (e.g., `CreateSession`)
95
97
- Java uses camelCase for methods (e.g., `createSession`) and PascalCase for classes
98
+
- Rust uses snake_case for functions and methods (e.g., `create_session`) and PascalCase for types
96
99
- Focus on public API methods when comparing across languages
97
100
3.**Focus on API surface**: Prioritize public APIs over internal implementation details
98
101
4.**Distinguish between bugs and features**:
@@ -105,7 +108,7 @@ When a pull request modifies any SDK client code, review it to ensure:
105
108
## Example Scenarios
106
109
107
110
### Good: Consistent feature addition
108
-
If a PR adds a new `setTimeout` option to the Node.js SDK and the equivalent feature already exists or is added to Python, Go, and .NET in the same PR.
111
+
If a PR adds a new `setTimeout` option to the Node.js SDK and the equivalent feature already exists or is added to Python, Go, .NET, Java, and Rust in the same PR.
109
112
110
113
### Bad: Inconsistent feature
111
114
If a PR adds a `withRetry` method to only the Python SDK, but this functionality doesn't exist in other SDKs and would be useful everywhere.
0 commit comments