Skip to content

Commit 2843622

Browse files
committed
Fix generated SDK build failures
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 217cbb68-9e90-4cf7-a02a-45e93f6938dd
1 parent b411f33 commit 2843622

18 files changed

Lines changed: 40 additions & 18 deletions

dotnet/src/Generated/SessionEvents.cs

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/definetool.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ func generateSchemaForType(t reflect.Type) map[string]any {
207207
}
208208

209209
// Handle pointer types
210-
if t.Kind() == reflect.Ptr {
210+
if t.Kind() == reflect.Pointer {
211211
t = t.Elem()
212212
}
213213

go/internal/e2e/event_fidelity_e2e_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ func TestEventFidelityE2E(t *testing.T) {
168168

169169
if answer == nil {
170170
t.Fatal("Expected SendAndWait to return an assistant message")
171+
return
171172
}
172173
if ad, ok := answer.Data.(*copilot.AssistantMessageData); !ok || !strings.Contains(ad.Content, "18") {
173174
t.Errorf("Expected answer to contain '18', got %v", answer.Data)

go/internal/e2e/rpc_server_e2e_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -604,6 +604,7 @@ func TestRPCServerE2E(t *testing.T) {
604604
projectSkillPath := findSkillDiscoveryPath(skillPaths.Paths, ctx.WorkDir)
605605
if projectSkillPath == nil {
606606
t.Fatalf("Expected skill discovery paths to include %q", ctx.WorkDir)
607+
return
607608
}
608609
if strings.TrimSpace(projectSkillPath.Path) == "" {
609610
t.Fatal("Expected non-empty skill discovery path")
@@ -632,6 +633,7 @@ func TestRPCServerE2E(t *testing.T) {
632633
projectAgentPath := findAgentDiscoveryPath(agentPaths.Paths, ctx.WorkDir)
633634
if projectAgentPath == nil {
634635
t.Fatalf("Expected agent discovery paths to include %q", ctx.WorkDir)
636+
return
635637
}
636638
if strings.TrimSpace(projectAgentPath.Path) == "" {
637639
t.Fatal("Expected non-empty agent discovery path")

go/internal/e2e/rpc_server_misc_e2e_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ func TestRpcServerMisc(t *testing.T) {
159159
}
160160
if users == nil {
161161
t.Fatal("Expected non-nil users result")
162+
return
162163
}
163164
for _, user := range *users {
164165
userInfo, ok := user.AuthInfo.(*rpc.UserAuthInfo)

go/internal/e2e/rpc_server_plugins_e2e_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ func TestRpcServerPlugins(t *testing.T) {
5858
listed := findPortedInstalledPlugin(afterInstall.Plugins, portedPluginName, portedMarketplaceName)
5959
if listed == nil {
6060
t.Fatalf("Expected installed plugin %q in marketplace %q", portedPluginName, portedMarketplaceName)
61+
return
6162
}
6263
if !listed.Enabled {
6364
t.Fatal("Expected listed marketplace plugin to be enabled")
@@ -229,6 +230,7 @@ func TestRpcServerPlugins(t *testing.T) {
229230
mine := findPortedMarketplace(list.Marketplaces, portedMarketplaceName)
230231
if mine == nil {
231232
t.Fatalf("Expected marketplace %q in list %+v", portedMarketplaceName, list.Marketplaces)
233+
return
232234
}
233235
if mine.IsDefault != nil && *mine.IsDefault {
234236
t.Fatal("Expected local marketplace not to be marked default")

go/internal/e2e/rpc_ui_ephemeral_query_e2e_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ func TestRpcUiEphemeralQuery(t *testing.T) {
2626
}
2727
if result == nil {
2828
t.Fatal("Expected non-nil ephemeral query result")
29+
return
2930
}
3031
if strings.TrimSpace(result.Answer) == "" {
3132
t.Fatal("Expected non-empty ephemeral query answer")

go/internal/e2e/system_message_sections_e2e_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ func TestSystemMessageSectionsE2E(t *testing.T) {
4343
}
4444
if response == nil {
4545
t.Fatal("Expected a response from the assistant")
46+
return
4647
}
4748

4849
ad, ok := response.Data.(*copilot.AssistantMessageData)
@@ -82,6 +83,7 @@ func TestSystemMessageSectionsE2E(t *testing.T) {
8283
}
8384
if response == nil {
8485
t.Fatal("Expected a response from the assistant")
86+
return
8587
}
8688

8789
ad, ok := response.Data.(*copilot.AssistantMessageData)

go/internal/e2e/tools_e2e_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ func TestToolsE2E(t *testing.T) {
140140

141141
if answer == nil {
142142
t.Fatalf("Expected non-nil assistant message")
143+
return
143144
}
144145
ad, ok := answer.Data.(*copilot.AssistantMessageData)
145146
if !ok {

java/src/main/java/com/github/copilot/CopilotClient.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -937,6 +937,7 @@ CompletableFuture<Void> updateSessionOptionsForMode(CopilotSession session, Bool
937937
null, // workingDirectory
938938
null, // availableTools
939939
null, // excludedTools
940+
null, // includedBuiltinAgents
940941
null, // excludedBuiltinAgents
941942
null, // toolFilterPrecedence
942943
null, // enableScriptSafety

0 commit comments

Comments
 (0)