fix: update async context manager exit methods to return None for exception propagation

Author: Sumanth007

python/copilot/client.py

@@ -236,30 +236,14 @@ async def __aexit__(
         exc_type: Optional[type[BaseException]],
         exc_val: Optional[BaseException],
         exc_tb: Optional[TracebackType],
-    ) -> bool:
+    ) -> None:
         """
         Exit the async context manager.
 
         Performs graceful cleanup by destroying all active sessions and stopping
-        the CLI server. If a cleanup error occurs and no exception was raised
-        inside the context, the cleanup error is propagated. If an exception
-        was already raised inside the context, the cleanup error is suppressed
-        so the original exception is not masked.
-
-        Args:
-            exc_type: The type of exception that occurred, if any.
-            exc_val: The exception instance that occurred, if any.
-            exc_tb: The traceback of the exception that occurred, if any.
-
-        Returns:
-            False to propagate any exception that occurred in the context.
+        the CLI server.
         """
-        try:
-            await self.stop()
-        except Exception:
-            if exc_type is None:
-                raise
-        return False
+        await self.stop()
 
     @property
     def rpc(self) -> ServerRpc:

python/copilot/session.py

@@ -108,30 +108,13 @@ async def __aexit__(
         exc_type: Optional[type[BaseException]],
         exc_val: Optional[BaseException],
         exc_tb: Optional[TracebackType],
-    ) -> bool:
+    ) -> None:
         """
         Exit the async context manager.
 
         Automatically destroys the session and releases all associated resources.
-        If a cleanup error occurs and no exception was raised inside the context,
-        the cleanup error is propagated. If an exception was already raised inside
-        the context, the cleanup error is suppressed so the original exception is
-        not masked.
-
-        Args:
-            exc_type: The type of exception that occurred, if any.
-            exc_val: The exception instance that occurred, if any.
-            exc_tb: The traceback of the exception that occurred, if any.
-
-        Returns:
-            False to propagate any exception that occurred in the context.
         """
-        try:
-            await self.destroy()
-        except Exception:
-            if exc_type is None:
-                raise
-        return False
+        await self.destroy()
 
     @property
     def rpc(self) -> SessionRpc:

python/test_client.py

@@ -328,33 +328,37 @@ async def test_client_context_manager_returns_self(self):
         await client.force_stop()
 
     @pytest.mark.asyncio
-    async def test_client_aexit_returns_false(self):
-        """Test that __aexit__ returns False to propagate exceptions."""
+    async def test_client_aexit_returns_none(self):
+        """Test that __aexit__ returns None to propagate exceptions."""
         client = CopilotClient({"cli_path": CLI_PATH})
         await client.start()
         result = await client.__aexit__(None, None, None)
-        assert result is False
+        assert result is None
 
     @pytest.mark.asyncio
     async def test_session_context_manager_returns_self(self):
         """Test that session __aenter__ returns the session instance."""
         client = CopilotClient({"cli_path": CLI_PATH})
         await client.start()
         try:
-            session = await client.create_session()
+            session = await client.create_session(
+                {"on_permission_request": PermissionHandler.approve_all}
+            )
             returned_session = await session.__aenter__()
             assert returned_session is session
         finally:
             await client.force_stop()
 
     @pytest.mark.asyncio
-    async def test_session_aexit_returns_false(self):
-        """Test that session __aexit__ returns False to propagate exceptions."""
+    async def test_session_aexit_returns_none(self):
+        """Test that session __aexit__ returns None to propagate exceptions."""
         client = CopilotClient({"cli_path": CLI_PATH})
         await client.start()
         try:
-            session = await client.create_session()
+            session = await client.create_session(
+                {"on_permission_request": PermissionHandler.approve_all}
+            )
             result = await session.__aexit__(None, None, None)
-            assert result is False
+            assert result is None
         finally:
             await client.force_stop()