You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix integration test to properly demonstrate package exclusion bug
The test was extracting from the entire workspace, which caused both
modules to be treated as input packages. This meant their ModDirs were
added to wantedRoots even without the fix, so the bug never manifested.
Changed test.py to extract only mainmodule packages using a specific
command pattern. This ensures:
- Only mainmodule is in the initial input packages
- configmodule is visited as a dependency
- Without the fix, configmodule's ModDir is NOT in wantedRoots
- The relative path check produces ".." and incorrectly excludes it
Test results:
- WITHOUT fix: 2 files extracted (configmodule missing) ❌
- WITH fix: 4 files extracted (all present) ✅
This addresses the reviewer's feedback that the test was passing
without any code changes.
0 commit comments