Remove a few overlay[caller] annotations to test warning

kaspersv · kaspersv · commit 8a3cff9a6cec · 2025-05-28T14:17:54.000+02:00
diff --git a/java/ql/lib/semmle/code/java/Type.qll b/java/ql/lib/semmle/code/java/Type.qll
@@ -670,7 +670,6 @@ class RefType extends Type, Annotatable, Modifiable, @reftype {
    *
    * For the definition of the notion of *erasure* see JLS v8, section 4.6 (Type Erasure).
    */
-  overlay[caller]
   pragma[inline]
   RefType commonSubtype(RefType other) {
     result.getASourceSupertype*() = erase(this) and
diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
@@ -744,7 +744,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
             viableImplNotCallContextReducedInlineLate(call, outercc)
           }
 
-          overlay[caller]
           pragma[inline]
           private predicate fwdFlowInCand(
             Call call, ArgNd arg, Cc outercc, Callable inner, ParamNd p, SummaryCtx summaryCtx,
@@ -796,7 +795,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
             innercc = getCallContextCall(call, inner)
           }
 
-          overlay[caller]
           pragma[inline]
           predicate fwdFlowIn(
             Call call, ArgNd arg, Callable inner, ParamNd p, Cc outercc, CcCall innercc,

Original file line number	Diff line number	Diff line change
`@@ -670,7 +670,6 @@ class RefType extends Type, Annotatable, Modifiable, @reftype {`
`670`	`670`	`*`
`671`	`671`	`* For the definition of the notion of erasure see JLS v8, section 4.6 (Type Erasure).`
`672`	`672`	`*/`
`673`		`- overlay[caller]`
`674`	`673`	`pragma[inline]`
`675`	`674`	`RefType commonSubtype(RefType other) {`
`676`	`675`	`result.getASourceSupertype*() = erase(this) and`
Original file line number	Diff line number	Diff line change
`@@ -744,7 +744,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`744`	`744`	`viableImplNotCallContextReducedInlineLate(call, outercc)`
`745`	`745`	`}`
`746`	`746`
`747`		`- overlay[caller]`
`748`	`747`	`pragma[inline]`
`749`	`748`	`private predicate fwdFlowInCand(`
`750`	`749`	`Call call, ArgNd arg, Cc outercc, Callable inner, ParamNd p, SummaryCtx summaryCtx,`
`@@ -796,7 +795,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`796`	`795`	`innercc = getCallContextCall(call, inner)`
`797`	`796`	`}`
`798`	`797`
`799`		`- overlay[caller]`
`800`	`798`	`pragma[inline]`
`801`	`799`	`predicate fwdFlowIn(`
`802`	`800`	`Call call, ArgNd arg, Callable inner, ParamNd p, Cc outercc, CcCall innercc,`