Move timeout check to end of loop instead of an extra iteration

Author: robertbrignull

lib/entry-points.js

@@ -861,20 +861,10 @@ export async function waitForProcessing(
     await util.delay(statusCheckBackoff, { allowProcessExit: false });
 
     for (
-      let statusCheckingCount = 0;
-      statusCheckingCount <= STATUS_CHECK_MAX_TRIES; // Aborts on the last loop iteration
-      statusCheckingCount++
+      let statusCheckCount = 1;
+      statusCheckCount <= STATUS_CHECK_MAX_TRIES;
+      statusCheckCount++
     ) {
-      if (statusCheckingCount === STATUS_CHECK_MAX_TRIES) {
-        // If the analysis hasn't finished processing in the allotted time, we continue anyway rather than failing.
-        // It's possible the analysis will eventually finish processing, but it's not worth spending more
-        // Actions time waiting.
-        logger.warning(
-          "Timed out waiting for analysis to finish processing. Continuing.",
-        );
-        break;
-      }
-
       let response: OctokitResponse<any> | undefined = undefined;
       try {
         response = await client.request(
@@ -921,6 +911,16 @@ export async function waitForProcessing(
 
       statusCheckBackoff *= STATUS_CHECK_BACKOFF_MULTIPLIER;
       await util.delay(statusCheckBackoff, { allowProcessExit: false });
+
+      if (statusCheckCount === STATUS_CHECK_MAX_TRIES) {
+        // If the analysis hasn't finished processing in the allotted time, we continue anyway rather than failing.
+        // It's possible the analysis will eventually finish processing, but it's not worth spending more
+        // Actions time waiting.
+        logger.warning(
+          "Timed out waiting for analysis to finish processing. Continuing.",
+        );
+        break;
+      }
     }
   } finally {
     logger.endGroup();