Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 8c5f0cf

Browse files
authored
Merge pull request #2460 from github/azure-pipelines/certificate-sha1
Sign the VSIX
2 parents 7884364 + 461208a commit 8c5f0cf

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

.github/workflows/main.yml

+4
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ jobs:
5353
GitHubVS_ClientId: ${{ secrets.GitHubVS_ClientId }}
5454
GitHubVS_ClientSecret: ${{ secrets.GitHubVS_ClientSecret }}
5555

56+
- name: Sign the VSIX
57+
if: github.ref == 'refs/heads/master'
58+
run: tools/vsixsigntool/vsixsigntool.exe sign /f certificate.pfx /p '${{ secrets.CERTIFICATE_PASSWORD }}' /sha1 9c5a6d389e1454f2ed9ee9419cdf743689709f9c /fd sha256 /tr http://timestamp.digicert.com /td sha256 ${{ env.vsixContainer }}
59+
5660
- name: Upload VSIX artifact
5761
uses: actions/upload-artifact@v1
5862
with:

GitHubVS.sln

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ EndProject
1313
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Meta", "Meta", "{72036B62-2FA6-4A22-8B33-69F698A18CF1}"
1414
ProjectSection(SolutionItems) = preProject
1515
.editorconfig = .editorconfig
16+
.github\workflows\main.yml = .github\workflows\main.yml
1617
README.md = README.md
1718
version.json = version.json
1819
EndProjectSection

azure-pipelines.yml

+5-6
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,11 @@ jobs:
100100
inputs:
101101
secureFile: certificate.pfx
102102

103-
# Disable VSIX signing
104-
# - script: $(vsixsigntool_exe.secureFilePath) sign /f $(certificate_pfx.secureFilePath) /p "$(certificate_password)" /sha1 c4fdf13659f49e57ac14774fdf45053f499f185f /fd sha256 /tr http://timestamp.digicert.com /td sha256 $(ArtifactDirectory)\GitHub.VisualStudio.vsix
105-
# displayName: Sign the GitHub for Visual Studio VSIX
106-
#
107-
# - script: $(vsixsigntool_exe.secureFilePath) sign /f $(certificate_pfx.secureFilePath) /p "$(certificate_password)" /sha1 c4fdf13659f49e57ac14774fdf45053f499f185f /fd sha256 /tr http://timestamp.digicert.com /td sha256 $(ArtifactDirectory)\GitHub.VisualStudio.16.vsix
108-
# displayName: Sign the GitHub Essentials VSIX
103+
- script: $(vsixsigntool_exe.secureFilePath) sign /f $(certificate_pfx.secureFilePath) /p "$(certificate_password)" /sha1 9c5a6d389e1454f2ed9ee9419cdf743689709f9c /fd sha256 /tr http://timestamp.digicert.com /td sha256 $(ArtifactDirectory)\GitHub.VisualStudio.vsix
104+
displayName: Sign the GitHub for Visual Studio VSIX
105+
106+
- script: $(vsixsigntool_exe.secureFilePath) sign /f $(certificate_pfx.secureFilePath) /p "$(certificate_password)" /sha1 9c5a6d389e1454f2ed9ee9419cdf743689709f9c /fd sha256 /tr http://timestamp.digicert.com /td sha256 $(ArtifactDirectory)\GitHub.VisualStudio.16.vsix
107+
displayName: Sign the GitHub Essentials VSIX
109108

110109
- task: PublishBuildArtifacts@1
111110
inputs:

certificate.pfx

4.21 KB
Binary file not shown.

tools/vsixsigntool/vsixsigntool.exe

63 KB
Binary file not shown.

0 commit comments

Comments
 (0)