Re-opened tickets

[bviktor]

Hi,

I must say that this plugin's really a must-have, many thanks for it.

Now I'm wondering what exactly happens when a ticket is declined and then reopened (or anything that deletes and then recreates the branch). IIRC the Git garbage collector's supposed to physically erase deleted branches after some time. I don't know the internals of this plugin so it's more of a question than a report: what happens when GC is enabled, the GC threshold has been reached and a ticket's been reopened after that? Will that mean that the previous patchset will be lost?

[gitblit]

Gitblit always protects patchsets - they are never in danger of being lost to GC. Each patchset has it's own ref which is not in the branches namespace. The ticket branch points to the tip of the current patchset. Removing the branch does not dereference the patchset's commits.

For example, for a ticket patchset which is never re-written, only fast-forwarded, there are 2 refs in Gitblit: the branch ref which is automatically fetched by clients and the patchset ref which is used internally by Gitblit. If you squash, rebase, amend, etc, and push that to Gitblit there are now 3 refs. ps-1, ps-2, and the branch. Rewrite again... ps-1, ps-2, ps-3, and the branch. The patchset refs are never discarded. The complete ticket patchset history is always recoverable.

[bviktor]

Cool, thank you very much!