Skip to content

Flipped naming convention #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
juan-tenorio opened this issue Jan 3, 2020 · 0 comments
Open

Flipped naming convention #19

juan-tenorio opened this issue Jan 3, 2020 · 0 comments

Comments

@juan-tenorio
Copy link
Contributor

It looks like the sourceBranchId and the targetBranchId variables are flipped as when we called this method we got the opposite of what we were expecting.

We set up the sourceBranchId to our working branch and the targetBranchId to master. We were expecting to the additions coming back but we are seeing deletion actions instead.

gitana-javascript-driver/js/gitana/repository/Repository.js

Line 517 in b7efbe6

startChanges: function(sourceBranchId, targetBranchId, options, callback)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juan-tenorio