Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git merge No conflict reported!! #129

Open
tangzhiqiang3 opened this issue May 18, 2022 · 1 comment
Open

git merge No conflict reported!! #129

tangzhiqiang3 opened this issue May 18, 2022 · 1 comment

Comments

@tangzhiqiang3
Copy link

tangzhiqiang3 commented May 18, 2022

local branch:
`
static int __clk_core_init(struct clk_core *core)
{
int ret;
struct clk_core *parent;
unsigned long rate;
int phase;

if (!core)
    return -EINVAL;

clk_prepare_lock();
core->hw->core = core;

ret = clk_pm_runtime_get(core);
if (ret)
    goto unlock;

...
}
`

after branch:
`
static int __clk_core_init(struct clk_core *core)
{
int ret;
struct clk_core *parent;
unsigned long rate;
int phase;

if (!core)
    return -EINVAL;

clk_prepare_lock();

/*
 * Set hw->core after grabbing the prepare_lock to synchronize with
 * callers of clk_core_fill_parent_index() where we treat hw->core
 * being NULL as the clk not being registered yet. This is crucial so
 * that clks aren't parented until their parent is fully registered.
 */
core->hw->core = core;

ret = clk_pm_runtime_get(core);
if (ret)
    goto unlock;

...
}
`

local branch:execute "git merge after"
`
static int __clk_core_init(struct clk_core *core)
{
int ret;
struct clk_core *parent;
unsigned long rate;
int phase;

if (!core)
    return -EINVAL;

clk_prepare_lock();
core->hw->core = core;

/*
 * Set hw->core after grabbing the prepare_lock to synchronize with
 * callers of clk_core_fill_parent_index() where we treat hw->core
 * being NULL as the clk not being registered yet. This is crucial so
 * that clks aren't parented until their parent is fully registered.
 */
core->hw->core = core;

ret = clk_pm_runtime_get(core);
if (ret)
    goto unlock;

...
}
`

Result In two occurrences after merge:"core->hw->core = core;", And it happens every time.

  1. Can this problem be fixed
  2. How can I modify the source code so that this does not happen
@tangzhiqiang3
Copy link
Author

tangzhiqiang3 commented May 18, 2022

git version 2.17.1 and git version 2.36.1 test result.

@schacon @matthewmccullough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant