Data model:

- remove pointless self-referencing alias (daum.net aliasing itself)
- disallow domain lists if an alias is set

Note: after this change, the data should pass the updated tests in WhoTracks.me:
whotracksme/whotracks.me@edfa924

Author: philipp-classen

db/patterns/daum.net.eno

@@ -2,7 +2,6 @@ name: Daum Search
 category: customer_interaction
 website_url: https://www.daum.net/
 organization: kakao
-alias: daum.net
 
 --- domains
 daum.net

db/patterns/google_analytics.eno

@@ -5,6 +5,7 @@ organization: google
 
 --- domains
 google-analytics.com
+googleoptimize.com
 region1.google-analytics.com
 googleanalytics.com
 --- domains

db/patterns/google_website_optimizer.eno

@@ -4,10 +4,6 @@ website_url: https://www.google.com/analytics/siteopt/prev
 organization: google
 alias: google_analytics
 
---- domains
-googleoptimize.com
---- domains
-
 --- filters
 ||google-analytics.com/siteopt.js
 --- filters

test/db/patterns.test.js

@@ -121,6 +121,32 @@ test(RESOURCE_PATH, async (t) => {
         }
       });
 
+      await t.test('alias must reference a different existing pattern', () => {
+        const alias = spec.field('alias').optionalStringValue();
+        if (alias) {
+          assert.notStrictEqual(
+            alias,
+            specName,
+            `${specFile} has a self-referring alias; remove the alias line`,
+          );
+          assert.ok(
+            specFiles.includes(`${alias}.eno`),
+            `${specFile} aliases to '${alias}' but db/patterns/${alias}.eno does not exist`,
+          );
+        }
+      });
+
+      await t.test('has no domains if it is an alias', () => {
+        const alias = spec.field('alias').optionalStringValue();
+        const domains = spec.field('domains').optionalStringValue() || '';
+        if (alias) {
+          assert.ok(
+            domains.length === 0,
+            `${specFile} is an alias of '${alias}' but still defines domains: ${domains.replace(/\n/g, ', ')}. Move them to '${alias}.eno'.`,
+          );
+        }
+      });
+
       await t.test('has valid filters', () => {
         const filters = spec.field('filters').optionalStringValue();
         if (filters) {