Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to no clear the search box when clicked outside #170

Open
erezrokah opened this issue Mar 2, 2023 · 7 comments · May be fixed by #184
Open

feat: Ability to no clear the search box when clicked outside #170

erezrokah opened this issue Mar 2, 2023 · 7 comments · May be fixed by #184

Comments

@erezrokah
Copy link

erezrokah commented Mar 2, 2023

Thank you for this lovely component 🚀

At the moment when you click outside the search box the text is cleared:

Are you open to add a configuration to control that behavior? Some users might prefer to keep the text they typed

@ghoshnirmalya
Copy link
Owner

@erezrokah Yes. That sounds like a reasonable request. Are you interested in adding that functionality?

@erezrokah
Copy link
Author

Sure I can submit PR. Thanks @ghoshnirmalya!

@chstavridis
Copy link

chstavridis commented Apr 7, 2023

What is the status of this issue? @ghoshnirmalya

@erezrokah
Copy link
Author

Sorry @chstavridis, that's on me I haven't been able to submit a PR yet. We'll try to do it this week

@alymkarimg
Copy link

hi guys, any way to fix this!

@ghoshnirmalya
Copy link
Owner

@alymkarimg I noticed that you created a PR and then closed it. Would you like to build that functionality? I can help.

@alymkarimg
Copy link

alymkarimg commented Oct 13, 2023 via email

@crnsh crnsh linked a pull request Oct 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants