Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to view assets in Electron #295

Open
Shubhdeep12 opened this issue Dec 20, 2023 · 1 comment
Open

Not able to view assets in Electron #295

Shubhdeep12 opened this issue Dec 20, 2023 · 1 comment
Labels
Type: Bug-confirmed Something isn't working

Comments

@Shubhdeep12
Copy link
Collaborator

Environment

What version are you running? Etc.

Steps to Reproduce

  1. Try previewing the span with span.op as resource.img in the spanDetails page both in the browser and in the Electron app

Expected Result

Ideally, the assets should be visible in the Electron app also

Actual Result

Browser
image

.

Local App
image

Reason - description of these spans with preview is treated as src for img tag and this description usually contains the path not the exact URL of assets(images).
In the browser, it works because local assets need a browser base path
but the electron app is opened on port 5317 locally, causing the error.

Solution brainstorm - there is a request with URL value in transaction data, which I think we can use.

@Shubhdeep12
Copy link
Collaborator Author

Same issue if we open spotlight in new tab using sidecar URL - http://localhost:8969/

@Shubhdeep12 Shubhdeep12 added the Type: Bug-confirmed Something isn't working label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug-confirmed Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant