Skip to content

Conversation

@malwilley
Copy link
Member

Searching open periods was not hooked up (and isn't useful anyway), so this allows us to hide the search bar altogether.

CleanShot 2025-11-11 at 15 25 22

@malwilley malwilley requested a review from a team November 11, 2025 23:26
@malwilley malwilley requested a review from a team as a code owner November 11, 2025 23:26
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 11, 2025
label: searchText,
}}
/>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Visual gaps in grid when search is disabled.

When searchBarEnabled is false, the Grid has only one child (FilterBar) but still uses a 3-column template columns="auto minmax(100px, 1fr) auto". This causes the second column (minmax(100px, 1fr)) to render as empty space, creating unwanted visual gaps. The grid columns need to be adjusted dynamically based on whether the search bar is visible.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected

@malwilley malwilley merged commit 408e1a9 into master Nov 12, 2025
48 checks passed
@malwilley malwilley deleted the malwilley/feat/add-config-for-hiding-search-bar branch November 12, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants