Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Spend allocation root allocation breaks when customers re-provision with different quota agreements #77545

Open
Angelodaniel opened this issue Sep 16, 2024 · 8 comments
Labels
Product Area: Settings - Spend Allocation Sync: Jira Apply to auto-create a Jira shadow ticket

Comments

@Angelodaniel
Copy link
Member

Angelodaniel commented Sep 16, 2024

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

Customer URL in Jira issue

  1. Currently customer X has for example 500M errors and setup allocation on that number
  2. if customer X renews but increases the errors to 550M, the Root allocation total counts break and the calculation is off.

Expected Result

Numbers to be calculated effectively

Actual Result

Errors
Image

Performance
Image

Product Area

Settings - Spend Allocation

Link

See Jira Issue

DSN

No response

Version

No response

┆Issue is synchronized with this Jira Improvement by Unito

@getsantry
Copy link
Contributor

getsantry bot commented Sep 16, 2024

Routing to @getsentry/product-owners-settings-spend-allocation for triage ⏲️

@Angelodaniel Angelodaniel added the Sync: Jira Apply to auto-create a Jira shadow ticket label Sep 16, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Sep 16, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 3 Sep 16, 2024
@Angelodaniel
Copy link
Member Author

I recall that I could resolve this by "disabling the spend allocation"
And re-setting it again, but this is a big effort especially at "scale" so it should not happen in the first place

@keradus
Copy link
Contributor

keradus commented Sep 16, 2024

very important topic 👍🏻

Be careful - disabled spend allocation, each sentry project can burn whole quota of whole contract, as no spend allocation is configured

Also, if someone wanted to give 5M quota to project A, and 10M to project B, while whole contract states for 15M - after quota were disabled, the spend allocation is no longer aware which project used how much quota and Sentry is not allowing to configure A=5M, B=10M as 15M totals are no longer available for configuration - only quota allowed to configure is one that was not yet used given billing cycle.

@brianthi
Copy link

Thanks for raising up this issue and concerns. I'm backlogging the issue for now and will share this feedback with our PM team for prioritization. If we pick this up, will provide an update in the issue.

@Angelodaniel
Copy link
Member Author

Hey @brianthi a month has gone by and the root allocation of the org is still broken. Can you revisit this as it will be a recurring problem each month until we have a fix for it in place.

Customers can potentially disable spend allocations and re-enable them directly after to "Reset" the numbers but at scale this becomes a big initiative which takes time and effort for the customer.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 14, 2024
@keradus
Copy link
Contributor

keradus commented Oct 14, 2024

Customers can potentially disable spend allocations and re-enable them directly after to "Reset" the numbers but at scale this becomes a big initiative which takes time and effort for the customer.

as a customer, I need to avoid that.
Disabling root allocation and re-enabling it later means that I lost the so-far "consumed" counter per project in spend-allocation.
Imagine - I want to configure 2M events for project X, they used 0.5M. What I see in spend-allocation is that 0.5M was used already. Then, when I "Reset" the root spend-allocation and re-enable it, I see that... 0M was used in project's spend allocation. So I need to manually check it was 0.5 and set 1.5 for remaining billing month period.

Then I have ~100 projects, solution does not scale

@brianthi
Copy link

Hi, unfortunately I don't have an update to share right now. We are very aware of the problems that this bug causes and are prioritizing it accordingly with the planned work and technical debt we have. We will update this ticket once we have a meaningful update to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Area: Settings - Spend Allocation Sync: Jira Apply to auto-create a Jira shadow ticket
Projects
Status: No status
Development

No branches or pull requests

5 participants