You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It iterates over each rule, and then over each action for a matching rule.
This can be suboptimal for multiple consecutive rules with similar matchers and the same actions, for example:
In this case, we would execute both matchers, and up to 4 of the rules if a matcher is indeed matching.
There are two possibilities to optimize this:
Merge consecutive matchers with the same actions
In the example above, the two enhancers can be merged into one, matching a function name of either _CxxThrowException or __cxa_throw.
Merge directional actions
Right now, ^-group -group is treated as two separate actions, upwards (less), and equal. It should be possible to merge these into a single action "less or equal".
The text was updated successfully, but these errors were encountered:
This is spawned out of #51354.
The main loop of enhancement rules looks like this:
sentry/src/sentry/grouping/enhancer/__init__.py
Lines 128 to 132 in ad474a7
It iterates over each rule, and then over each action for a matching rule.
This can be suboptimal for multiple consecutive rules with similar matchers and the same actions, for example:
In this case, we would execute both matchers, and up to 4 of the rules if a matcher is indeed matching.
There are two possibilities to optimize this:
Merge consecutive matchers with the same actions
In the example above, the two enhancers can be merged into one, matching a function name of either
_CxxThrowException
or__cxa_throw
.Merge directional actions
Right now,
^-group -group
is treated as two separate actions, upwards (less), and equal. It should be possible to merge these into a single action "less or equal".The text was updated successfully, but these errors were encountered: