Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only eagerly process main/primary stack trace #51519

Open
Swatinem opened this issue Jun 23, 2023 · 0 comments
Open

Only eagerly process main/primary stack trace #51519

Swatinem opened this issue Jun 23, 2023 · 0 comments

Comments

@Swatinem
Copy link
Member

Related to #51517 and #51518. And also getsentry/rfcs#106 eventually.

We want to only do the minimum amount of work necessary to properly group an event, and to display its primary / main thread stack trace.

We assume that the number of users that actually look at a background thread stack trace is very low. It should be possible to skip a ton of work, and do that work on-demand when a user switches to a background thread in the main event UI.

This work includes:

  • Symbolication and source context application.
  • Enhancement rules that categorize the stack frames and influence how it is displayed in the UI.

Apart from avoiding a ton of processing resources on things that users are extremely unlikely to ever look at, we would also save on storage costs as those parts of the event payload would only be backfilled on demand.

Doing this however is a high-effort initiative as it touches on a lot of places in the whole pipeline. Its success is also dependent on:

  • Availability of minidumps, as they are needed to retroactively stack walk background threads if that is not done eagerly.
  • Availability of debug symbols and source maps. As we are currently thinking about / planning for newer uploads to artifact bundles overwriting previously uploaded files, this means that older events might not resolve the same with newer debug files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant