feat(seer-settings): Support ProjectRepository CRUD for token-based billing in Seer project repos API (#128705)

Relates to CW-2250

Under token-based billing, the Seer project repos API lists every linked
repo Seer can use, with `SeerProjectRepository` as optional per-repo
config.

Under token-based billing, Seer only uses linked repos that are active,
have a supported provider, and have an integration and external ID.
Every endpoint applies these checks.

- `/seer/repos/`
  - GET lists every usable linked repo, with or without a config row.
  - POST adds repos and their config.
- PUT ("replace all") is unchanged except for the stricter validation.
Its only caller is the projectAddRepoModal.tsx, which only offers
projects with no Seer repos. For token-based billing, repos are
automatically linked to projects, so it'd make more sense to call POST
to bulk update config instead of PUT.
- `/seer/repos/{repo_id}/`
- GET returns the repo even without a config row, and 404s if Seer can't
use it.
  - PUT creates the config row if needed.
- DELETE returns 400. Deleting the project-repo link doesn't make sense
for token-based billing. Use PUT to set the config row back to default.

Responses now return the `ProjectRepository` ID (instead of
`SeerProjectRepository` id) as `id` for both seat-based and token-based
orgs. This is ok because [the frontend list keys by repo
id](https://github.com/getsentry/sentry/blob/a06ba545e582348b7b8a236a8176c9312d257aff/static/app/components/seer/projectDetails/autofixRepositoriesList.tsx#L180),
and the API takes project and repo ids for CRUD.

Author: srest2021

src/sentry/seer/autofix/utils.py

@@ -492,6 +492,11 @@ def get_token_based_billing_project_repos(
     )
 
 
+def get_seer_project_repo(project_repo: ProjectRepository) -> SeerProjectRepository | None:
+    """Avoid raising RelatedObjectDoesNotExist when ProjectRepository has no SeerProjectRepository."""
+    return getattr(project_repo, "seerprojectrepository", None)
+
+
 def build_seer_repo_definition(
     repo: Repository, seer_project_repo: SeerProjectRepository | None
 ) -> SeerRepoDefinition | None:
@@ -530,9 +535,8 @@ def _get_repo_definitions_by_project(
     repo_definitions_by_project: defaultdict[int, list[SeerRepoDefinition]] = defaultdict(list)
     if is_seer_token_based_billing_onboarding_enabled(organization):
         for project_repo in get_token_based_billing_project_repos(organization, project_ids):
-            # getattr since accessing a missing one-to-one raises RelatedObjectDoesNotExist.
             repo_def = build_seer_repo_definition(
-                project_repo.repository, getattr(project_repo, "seerprojectrepository", None)
+                project_repo.repository, get_seer_project_repo(project_repo)
             )
             if repo_def is not None:
                 repo_definitions_by_project[project_repo.project_id].append(repo_def)
@@ -744,6 +748,44 @@ class ProjectRepoCreateData(TypedDict):
     branch_overrides: NotRequired[list[BranchOverrideData]]
 
 
+class ProjectRepoUpdateData(TypedDict):
+    branch_name: NotRequired[str | None]
+    instructions: NotRequired[str | None]
+    branch_overrides: NotRequired[list[BranchOverrideData]]
+
+
+def update_seer_project_repo(
+    seer_project_repo: SeerProjectRepository, data: ProjectRepoUpdateData
+) -> None:
+    """Update a Seer project repo's config. Fields missing from data are left unchanged."""
+    if "branch_name" in data:
+        seer_project_repo.branch_name = data["branch_name"]
+    if "instructions" in data:
+        seer_project_repo.instructions = data["instructions"]
+    if "branch_name" in data or "instructions" in data:
+        seer_project_repo.save()
+
+    if "branch_overrides" in data:
+        SeerProjectRepositoryBranchOverride.objects.filter(
+            seer_project_repository=seer_project_repo
+        ).delete()
+        if data["branch_overrides"]:
+            SeerProjectRepositoryBranchOverride.objects.bulk_create(
+                [
+                    SeerProjectRepositoryBranchOverride(
+                        seer_project_repository=seer_project_repo,
+                        tag_name=override["tag_name"],
+                        tag_value=override["tag_value"],
+                        branch_name=override["branch_name"],
+                    )
+                    for override in data["branch_overrides"]
+                ],
+                update_conflicts=True,
+                update_fields=["branch_name", "date_updated"],
+                unique_fields=["seer_project_repository", "tag_name", "tag_value"],
+            )
+
+
 def add_seer_project_repos(project: Project, repos_data: list[ProjectRepoCreateData]) -> list[int]:
     """Upsert Seer project repos."""
     if not repos_data:

src/sentry/seer/endpoints/project_seer_repos.py

@@ -5,7 +5,7 @@
 from typing import TypedDict
 
 from django.db import router, transaction
-from django.db.models import Value
+from django.db.models import QuerySet, Value
 from django.db.models.functions import Replace
 from rest_framework import serializers
 from rest_framework.request import Request
@@ -21,21 +21,24 @@
 from sentry.api.serializers.rest_framework import CamelSnakeSerializer
 from sentry.constants import ObjectStatus
 from sentry.exceptions import InvalidSearchQuery
+from sentry.models.organization import Organization
 from sentry.models.project import Project
+from sentry.models.projectrepository import ProjectRepository
 from sentry.models.repository import Repository
 from sentry.seer.autofix.utils import (
     add_seer_project_repos,
+    get_seer_project_repo,
+    get_token_based_billing_project_repos,
+    is_seer_token_based_billing_onboarding_enabled,
     replace_all_seer_project_repos,
+    update_seer_project_repo,
 )
-from sentry.seer.models.project_repository import (
-    SeerProjectRepository,
-    SeerProjectRepositoryBranchOverride,
-)
+from sentry.seer.models.project_repository import SeerProjectRepository
 from sentry.seer.seer_setup import get_supported_scm_providers
 
 SORT_FIELDS_MAPPING: dict[str, str] = {
-    "name": "project_repository__repository__name",
-    "-name": "-project_repository__repository__name",
+    "name": "repository__name",
+    "-name": "-repository__name",
     "provider": "provider_normalized",
     "-provider": "-provider_normalized",
 }
@@ -67,8 +70,10 @@ class ProjectRepoResponse(TypedDict):
     instructions: str | None
 
 
-def _serialize_project_repo(project_repo: SeerProjectRepository) -> ProjectRepoResponse:
-    repo = project_repo.project_repository.repository
+def _serialize_project_repo(
+    project_repo: ProjectRepository, seer_project_repo: SeerProjectRepository | None
+) -> ProjectRepoResponse:
+    repo = project_repo.repository
     name_parts = repo.name.split("/", 1)
     owner = name_parts[0] if len(name_parts) > 1 else ""
     name = name_parts[1] if len(name_parts) > 1 else repo.name
@@ -82,21 +87,26 @@ def _serialize_project_repo(project_repo: SeerProjectRepository) -> ProjectRepoR
         name=name,
         externalId=repo.external_id or "",
         integrationId=str(repo.integration_id) if repo.integration_id is not None else None,
-        branchName=project_repo.branch_name,
-        branchOverrides=[
-            BranchOverrideResponse(
-                id=str(bo.id),
-                tagName=bo.tag_name,
-                tagValue=bo.tag_value,
-                branchName=bo.branch_name,
-            )
-            for bo in project_repo.branch_overrides.all()
-        ],
-        instructions=project_repo.instructions,
+        branchName=seer_project_repo.branch_name if seer_project_repo else None,
+        branchOverrides=(
+            [
+                BranchOverrideResponse(
+                    id=str(bo.id),
+                    tagName=bo.tag_name,
+                    tagValue=bo.tag_value,
+                    branchName=bo.branch_name,
+                )
+                for bo in seer_project_repo.branch_overrides.all()
+            ]
+            if seer_project_repo
+            else []
+        ),
+        instructions=seer_project_repo.instructions if seer_project_repo else None,
     )
 
 
-def _valid_project_repos_queryset(project: Project):
+def _get_seat_based_billing_seer_project_repos(project: Project) -> QuerySet[SeerProjectRepository]:
+    """SeerProjectRepository Seer can use under seat-based billing."""
     return SeerProjectRepository.objects.filter(
         project_repository__project=project,
         project_repository__repository__status=ObjectStatus.ACTIVE,
@@ -106,17 +116,49 @@ def _valid_project_repos_queryset(project: Project):
     ).select_related("project_repository", "project_repository__repository")
 
 
+def _get_seat_based_billing_project_repos(project: Project) -> QuerySet[ProjectRepository]:
+    """ProjectRepository Seer can use under seat-based billing."""
+    return (
+        ProjectRepository.objects.filter(
+            project=project,
+            seerprojectrepository__isnull=False,
+            repository__status=ObjectStatus.ACTIVE,
+            repository__provider__in=get_supported_scm_providers(project.organization),
+        )
+        .select_related("repository", "seerprojectrepository")
+        .prefetch_related("seerprojectrepository__branch_overrides")
+    )
+
+
+def _get_seat_based_billing_repos(organization: Organization) -> QuerySet[Repository]:
+    """Repos Seer can use under seat-based billing."""
+    return Repository.objects.filter(
+        organization_id=organization.id,
+        status=ObjectStatus.ACTIVE,
+        provider__in=get_supported_scm_providers(organization),
+    )
+
+
+def _get_token_based_billing_repos(organization: Organization) -> QuerySet[Repository]:
+    """Repos Seer can use under token-based billing. Same checks as get_token_based_billing_project_repos."""
+    return Repository.objects.filter(
+        organization_id=organization.id,
+        status=ObjectStatus.ACTIVE,
+        provider__in=get_supported_scm_providers(organization),
+        integration_id__isnull=False,
+        external_id__isnull=False,
+    ).exclude(external_id="")
+
+
 def _validate_repo_ids(project: Project, repo_ids: list[int]) -> None:
     """Raise ValueError if any repo IDs are invalid, inactive, or have providers not supported by Seer."""
     organization = project.organization
-    valid_ids = set(
-        Repository.objects.filter(
-            id__in=repo_ids,
-            organization_id=organization.id,
-            status=ObjectStatus.ACTIVE,
-            provider__in=get_supported_scm_providers(organization),
-        ).values_list("id", flat=True)
+    repos = (
+        _get_token_based_billing_repos(organization)
+        if is_seer_token_based_billing_onboarding_enabled(organization)
+        else _get_seat_based_billing_repos(organization)
     )
+    valid_ids = set(repos.filter(id__in=repo_ids).values_list("id", flat=True))
     invalid_ids = set(repo_ids) - valid_ids
     if invalid_ids:
         raise ValueError(sorted(invalid_ids))
@@ -135,9 +177,9 @@ def _apply_search_filters(queryset, filters: Sequence[QueryToken]):
             if op not in ("=", "!="):
                 raise InvalidSearchQuery(f"name does not support the {op} operator.")
             if op == "=":
-                queryset = queryset.filter(project_repository__repository__name__icontains=value)
+                queryset = queryset.filter(repository__name__icontains=value)
             elif op == "!=":
-                queryset = queryset.exclude(project_repository__repository__name__icontains=value)
+                queryset = queryset.exclude(repository__name__icontains=value)
 
         elif key == "provider":
             if op not in ("=", "!=", "IN", "NOT IN"):
@@ -219,16 +261,16 @@ class ProjectSeerRepoEndpoint(ProjectEndpoint):
     }
 
     def get(self, request: Request, project: Project, repo_id: int) -> Response:
-        project_repo = (
-            _valid_project_repos_queryset(project)
-            .prefetch_related("branch_overrides")
-            .filter(project_repository__repository_id=repo_id)
-            .first()
+        project_repos_qs = (
+            get_token_based_billing_project_repos(project.organization, [project.id])
+            if is_seer_token_based_billing_onboarding_enabled(project.organization)
+            else _get_seat_based_billing_project_repos(project)
         )
+        project_repo = project_repos_qs.filter(repository_id=repo_id).first()
         if project_repo is None:
             return Response(status=404)
 
-        return Response(_serialize_project_repo(project_repo))
+        return Response(_serialize_project_repo(project_repo, get_seer_project_repo(project_repo)))
 
     def put(self, request: Request, project: Project, repo_id: int) -> Response:
         serializer = SeerProjectRepoUpdateSerializer(data=request.data)
@@ -237,49 +279,46 @@ def put(self, request: Request, project: Project, repo_id: int) -> Response:
 
         data = serializer.validated_data
 
+        seer_project_repo: SeerProjectRepository | None
         with transaction.atomic(router.db_for_write(SeerProjectRepository)):
-            project_repo = (
-                _valid_project_repos_queryset(project)
-                .select_for_update()
-                .filter(project_repository__repository_id=repo_id)
-                .first()
-            )
-            if project_repo is None:
-                return Response(status=404)
-
-            if "branch_name" in data:
-                project_repo.branch_name = data["branch_name"]
-            if "instructions" in data:
-                project_repo.instructions = data["instructions"]
-            if "branch_name" in data or "instructions" in data:
-                project_repo.save()
-
-            if "branch_overrides" in data:
-                SeerProjectRepositoryBranchOverride.objects.filter(
-                    seer_project_repository=project_repo
-                ).delete()
-                if data["branch_overrides"]:
-                    SeerProjectRepositoryBranchOverride.objects.bulk_create(
-                        [
-                            SeerProjectRepositoryBranchOverride(
-                                seer_project_repository=project_repo,
-                                tag_name=override["tag_name"],
-                                tag_value=override["tag_value"],
-                                branch_name=override["branch_name"],
-                            )
-                            for override in data["branch_overrides"]
-                        ],
-                        update_conflicts=True,
-                        update_fields=["branch_name", "date_updated"],
-                        unique_fields=["seer_project_repository", "tag_name", "tag_value"],
+            if is_seer_token_based_billing_onboarding_enabled(project.organization):
+                project_repo = (
+                    get_token_based_billing_project_repos(project.organization, [project.id])
+                    .filter(repository_id=repo_id)
+                    .first()
+                )
+                if project_repo is None:
+                    return Response(status=404)
+
+                seer_project_repo, _ = (
+                    SeerProjectRepository.objects.select_for_update().get_or_create(
+                        project_repository=project_repo
                     )
+                )
+            else:
+                seer_project_repo = (
+                    _get_seat_based_billing_seer_project_repos(project)
+                    .select_for_update()
+                    .filter(project_repository__repository_id=repo_id)
+                    .first()
+                )
+                if seer_project_repo is None:
+                    return Response(status=404)
+                project_repo = seer_project_repo.project_repository
+
+            update_seer_project_repo(seer_project_repo, data)
 
-        return Response(_serialize_project_repo(project_repo))
+        return Response(_serialize_project_repo(project_repo, seer_project_repo))
 
     def delete(self, request: Request, project: Project, repo_id: int) -> Response:
+        if is_seer_token_based_billing_onboarding_enabled(project.organization):
+            # Under token-based billing Seer uses every linked project repo,
+            # so there's nothing to remove.
+            return Response({"detail": "Repositories can't be removed from Seer."}, status=400)
+
         with transaction.atomic(router.db_for_write(SeerProjectRepository)):
             deleted_count, _ = (
-                _valid_project_repos_queryset(project)
+                _get_seat_based_billing_seer_project_repos(project)
                 .filter(project_repository__repository_id=repo_id)
                 .delete()
             )
@@ -301,13 +340,11 @@ class ProjectSeerReposEndpoint(ProjectEndpoint):
 
     def get(self, request: Request, project: Project) -> Response:
         queryset = (
-            _valid_project_repos_queryset(project)
-            .prefetch_related("branch_overrides")
-            .annotate(
-                provider_normalized=Replace(
-                    "project_repository__repository__provider", Value("integrations:"), Value("")
-                )
-            )
+            get_token_based_billing_project_repos(project.organization, [project.id])
+            if is_seer_token_based_billing_onboarding_enabled(project.organization)
+            else _get_seat_based_billing_project_repos(project)
+        ).annotate(
+            provider_normalized=Replace("repository__provider", Value("integrations:"), Value(""))
         )
 
         search_query = request.GET.get("query", "")
@@ -327,7 +364,9 @@ def get(self, request: Request, project: Project) -> Response:
             request=request,
             queryset=queryset,
             order_by=order_by,
-            on_results=lambda results: [_serialize_project_repo(r) for r in results],
+            on_results=lambda results: [
+                _serialize_project_repo(r, get_seer_project_repo(r)) for r in results
+            ],
             paginator_cls=OffsetPaginator,
         )