Cleanups

Author: rbro112

static/app/views/preprod/buildComparison/main/sizeCompareSelectionContent.tsx

@@ -23,7 +23,6 @@ import {
 } from 'sentry/icons';
 import {IconBranch} from 'sentry/icons/iconBranch';
 import {t} from 'sentry/locale';
-import {formatBytesBase10} from 'sentry/utils/bytes/formatBytesBase10';
 import parseLinkHeader from 'sentry/utils/parseLinkHeader';
 import {useApiQuery, useMutation, type UseApiQueryResult} from 'sentry/utils/queryClient';
 import {decodeScalar} from 'sentry/utils/queryString';
@@ -35,11 +34,14 @@ import useOrganization from 'sentry/utils/useOrganization';
 import {useParams} from 'sentry/utils/useParams';
 import {
   BuildDetailsState,
-  getPrimarySizeMetric,
   isSizeInfoCompleted,
   type BuildDetailsApiResponse,
 } from 'sentry/views/preprod/types/buildDetailsTypes';
 import type {ListBuildsApiResponse} from 'sentry/views/preprod/types/listBuildsTypes';
+import {
+  formattedPrimaryMetricDownloadSize,
+  formattedPrimaryMetricInstallSize,
+} from 'sentry/views/preprod/utils/labelUtils';
 
 import {SizeCompareSelectedBuilds} from './sizeCompareSelectedBuilds';
 
@@ -250,21 +252,13 @@ function BuildItem({build, isSelected, onSelect}: BuildItemProps) {
           {isSizeInfoCompleted(sizeInfo) && (
             <Flex align="center" gap="sm">
               <IconCode size="xs" color="gray300" />
-              <Text>
-                {formatBytesBase10(
-                  getPrimarySizeMetric(sizeInfo)?.install_size_bytes ?? 0
-                )}
-              </Text>
+              <Text>{formattedPrimaryMetricInstallSize(sizeInfo)}</Text>
             </Flex>
           )}
           {isSizeInfoCompleted(sizeInfo) && (
             <Flex align="center" gap="sm">
               <IconDownload size="xs" color="gray300" />
-              <Text>
-                {formatBytesBase10(
-                  getPrimarySizeMetric(sizeInfo)?.download_size_bytes ?? 0
-                )}
-              </Text>
+              <Text>{formattedPrimaryMetricDownloadSize(sizeInfo)}</Text>
             </Flex>
           )}
         </Flex>

static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarAppInfo.tsx

@@ -15,11 +15,13 @@ import {openInstallModal} from 'sentry/views/preprod/components/installModal';
 import {MetricsArtifactType} from 'sentry/views/preprod/types/appSizeTypes';
 import {
   BuildDetailsSizeAnalysisState,
-  getPrimarySizeMetric,
+  getMainArtifactSizeMetric,
   type BuildDetailsAppInfo,
   type BuildDetailsSizeInfo,
 } from 'sentry/views/preprod/types/buildDetailsTypes';
 import {
+  formattedPrimaryMetricDownloadSize,
+  formattedPrimaryMetricInstallSize,
   getLabels,
   getPlatformIconFromPlatform,
   getReadableArtifactTypeLabel,
@@ -47,20 +49,16 @@ export function BuildDetailsSidebarAppInfo(props: BuildDetailsSidebarAppInfoProp
     props.sizeInfo &&
     props.sizeInfo.state === BuildDetailsSizeAnalysisState.COMPLETED
   ) {
-    const primarySizeMetric = getPrimarySizeMetric(props.sizeInfo);
+    const primarySizeMetric = getMainArtifactSizeMetric(props.sizeInfo);
     const watchAppMetrics = props.sizeInfo.size_metrics.find(
       metric => metric.metrics_artifact_type === MetricsArtifactType.WATCH_ARTIFACT
     );
 
     let installSizeContent = (
-      <Text size="md">
-        {formatBytesBase10(primarySizeMetric?.install_size_bytes ?? 0)}
-      </Text>
+      <Text size="md">{formattedPrimaryMetricInstallSize(props.sizeInfo)}</Text>
     );
     let downloadSizeContent = (
-      <Text size="md">
-        {formatBytesBase10(primarySizeMetric?.download_size_bytes ?? 0)}
-      </Text>
+      <Text size="md">{formattedPrimaryMetricDownloadSize(props.sizeInfo)}</Text>
     );
     if (watchAppMetrics) {
       installSizeContent = (
@@ -88,7 +86,7 @@ export function BuildDetailsSidebarAppInfo(props: BuildDetailsSidebarAppInfoProp
           position="left"
         >
           <Text size="md" underline="dotted">
-            {formatBytesBase10(primarySizeMetric?.install_size_bytes ?? 0)}
+            {formattedPrimaryMetricInstallSize(props.sizeInfo)}
           </Text>
         </Tooltip>
       );
@@ -117,7 +115,7 @@ export function BuildDetailsSidebarAppInfo(props: BuildDetailsSidebarAppInfoProp
           position="left"
         >
           <Text size="md" underline="dotted">
-            {formatBytesBase10(primarySizeMetric?.download_size_bytes ?? 0)}
+            {formattedPrimaryMetricDownloadSize(props.sizeInfo)}
           </Text>
         </Tooltip>
       );

static/app/views/preprod/types/buildDetailsTypes.ts

@@ -91,7 +91,7 @@ export function isSizeInfoProcessing(
   );
 }
 
-export function getPrimarySizeMetric(
+export function getMainArtifactSizeMetric(
   sizeInfo: BuildDetailsSizeInfoCompleted
 ): BuildDetailsSizeInfoSizeMetric | undefined {
   return sizeInfo.size_metrics.find(

static/app/views/preprod/utils/labelUtils.tsx

@@ -3,9 +3,9 @@ import {formatBytesBase10} from 'sentry/utils/bytes/formatBytesBase10';
 import {unreachable} from 'sentry/utils/unreachable';
 import {
   BuildDetailsArtifactType,
-  getPrimarySizeMetric,
+  getMainArtifactSizeMetric,
   isSizeInfoCompleted,
-  type BuildDetailsApiResponse,
+  type BuildDetailsSizeInfo,
 } from 'sentry/views/preprod/types/buildDetailsTypes';
 import type {Platform} from 'sentry/views/preprod/types/sharedTypes';
 
@@ -115,18 +115,30 @@ export function getReadablePlatformLabel(platform: Platform): string {
   }
 }
 
-export function formattedInstallSize(build: BuildDetailsApiResponse): string {
-  if (isSizeInfoCompleted(build?.size_info)) {
-    const primarySizeMetric = getPrimarySizeMetric(build.size_info);
-    return formatBytesBase10(primarySizeMetric?.install_size_bytes ?? 0);
+export function formattedPrimaryMetricInstallSize(
+  sizeInfo: BuildDetailsSizeInfo | undefined
+): string {
+  if (isSizeInfoCompleted(sizeInfo)) {
+    const primarySizeMetric = getMainArtifactSizeMetric(sizeInfo);
+    if (!primarySizeMetric) {
+      return '-';
+    }
+
+    return formatBytesBase10(primarySizeMetric.install_size_bytes);
   }
   return '-';
 }
 
-export function formattedDownloadSize(build: BuildDetailsApiResponse): string {
-  if (isSizeInfoCompleted(build?.size_info)) {
-    const primarySizeMetric = getPrimarySizeMetric(build.size_info);
-    return formatBytesBase10(primarySizeMetric?.download_size_bytes ?? 0);
+export function formattedPrimaryMetricDownloadSize(
+  sizeInfo: BuildDetailsSizeInfo | undefined
+): string {
+  if (isSizeInfoCompleted(sizeInfo)) {
+    const primarySizeMetric = getMainArtifactSizeMetric(sizeInfo);
+    if (!primarySizeMetric) {
+      return '-';
+    }
+
+    return formatBytesBase10(primarySizeMetric.download_size_bytes);
   }
   return '-';
 }