Repository navigation
Commit 72a59ef
fix(seer-embeds): Describe alert and monitor embeds in current terms (#127914)
Seer's `alert` and `monitor` embed descriptions used the old "metric /
issue / uptime / cron alert" model. When asked to create a Monitor that
emails on trigger, Seer tagged the new Alert's workflow ID as `kind:
"metric"`, so the card fetched `/detectors/<workflow id>/` and showed
"Unable to load alert details."
This rewrites both descriptions in current [Monitors and
Alerts](https://docs.sentry.io/product/monitors-and-alerts/) terms: a
Monitor (detector) decides when data becomes an issue, and an Alert
(workflow) acts on those issues. Alerts always use their workflow ID
with `kind: "issue"`. The `metric`/`uptime`/`cron` values stay in the
enum so saved conversations still render, but they're marked legacy and
removed from the examples.
Text-only: `schemas.ts` plus the regenerated
`embed_widgets.generated.json`; renderers are unchanged. Conversations
already saved with the wrong `kind` still show the error, and Seer's
evals don't include these embeds yet.
<!-- junior-request-attribution:start -->
via **matt.duncan**.
<!-- junior-request-attribution:end -->
<!-- junior-session-footer:start -->
<!-- junior-conversation-id:slack%3AC0C8Z02BG5Q%3A1792193306.342849 -->
--
[View Junior
Session](https://junior-prod.sentry.dev/conversations/slack%3AC0C8Z02BG5Q%3A1792193306.342849)
[[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0C8Z02BG5Q%3A1792193306.342849/?project=4510944073809921)
<!-- junior-session-footer:end -->
---------
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Matt Duncan <matt.duncan@sentry.io>
Co-authored-by: Matt Duncan <14761+mrduncan@users.noreply.github.com>1 parent 700fb8b commit 72a59ef
2 files changed
Lines changed: 42 additions & 46 deletions
File tree
- src/sentry/seer/agent
- static/app/components/seer/markdown/embeds
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
574 | 574 | | |
575 | 575 | | |
576 | 576 | | |
577 | | - | |
| 577 | + | |
578 | 578 | | |
579 | 579 | | |
580 | 580 | | |
| |||
586 | 586 | | |
587 | 587 | | |
588 | 588 | | |
589 | | - | |
| 589 | + | |
| 590 | + | |
590 | 591 | | |
591 | 592 | | |
592 | 593 | | |
| |||
597 | 598 | | |
598 | 599 | | |
599 | 600 | | |
600 | | - | |
601 | | - | |
602 | | - | |
603 | | - | |
604 | | - | |
605 | | - | |
606 | | - | |
607 | | - | |
608 | | - | |
| 601 | + | |
609 | 602 | | |
610 | 603 | | |
611 | | - | |
| 604 | + | |
| 605 | + | |
612 | 606 | | |
613 | 607 | | |
614 | 608 | | |
615 | | - | |
| 609 | + | |
616 | 610 | | |
617 | | - | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | | - | |
622 | | - | |
623 | | - | |
624 | | - | |
625 | | - | |
626 | | - | |
627 | | - | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
628 | 614 | | |
629 | 615 | | |
630 | 616 | | |
631 | 617 | | |
632 | 618 | | |
633 | 619 | | |
634 | | - | |
| 620 | + | |
635 | 621 | | |
636 | 622 | | |
637 | 623 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
448 | 453 | | |
449 | 454 | | |
450 | | - | |
451 | | - | |
| 455 | + | |
452 | 456 | | |
453 | 457 | | |
454 | 458 | | |
455 | 459 | | |
456 | 460 | | |
457 | | - | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
458 | 467 | | |
459 | 468 | | |
460 | 469 | | |
461 | 470 | | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
| 471 | + | |
| 472 | + | |
469 | 473 | | |
470 | 474 | | |
471 | | - | |
472 | | - | |
| 475 | + | |
| 476 | + | |
473 | 477 | | |
474 | 478 | | |
475 | 479 | | |
476 | 480 | | |
477 | 481 | | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
482 | 492 | | |
483 | 493 | | |
484 | | - | |
| 494 | + | |
485 | 495 | | |
486 | 496 | | |
487 | 497 | | |
| |||
0 commit comments