update type t be optional

Author: priscilawebdev

src/sentry/buffer/redis.py

@@ -284,7 +284,7 @@ def _dump_values(cls, values: dict[Any, Any]) -> dict[Any, tuple[str, str]]:
         return result
 
     @classmethod
-    def _dump_value(cls, value: str | datetime | date | int | float) -> tuple[str, str]:
+    def _dump_value(cls, value: str | datetime | date | int | float | None) -> tuple[str, str]:
         if isinstance(value, str):
             type_ = "s"
         elif isinstance(value, datetime):
@@ -297,21 +297,23 @@ def _dump_value(cls, value: str | datetime | date | int | float) -> tuple[str, s
             type_ = "i"
         elif isinstance(value, float):
             type_ = "f"
+        elif value is None:
+            return "n", ""
         else:
             raise TypeError(type(value))
         return type_, str(value)
 
     @classmethod
     def _load_values(
         cls, payload: dict[str, tuple[str, Any]]
-    ) -> dict[str, str | datetime | date | int | float]:
+    ) -> dict[str, str | datetime | date | int | float | None]:
         result = {}
         for k, (t, v) in payload.items():
             result[k] = cls._load_value((t, v))
         return result
 
     @classmethod
-    def _load_value(cls, payload: tuple[str, Any]) -> str | datetime | date | int | float:
+    def _load_value(cls, payload: tuple[str, Any]) -> str | datetime | date | int | float | None:
         (type_, value) = payload
         if type_ == "s":
             return force_str(value)
@@ -323,6 +325,8 @@ def _load_value(cls, payload: tuple[str, Any]) -> str | datetime | date | int |
             return int(value)
         elif type_ == "f":
             return float(value)
+        elif type_ == "n":
+            return None
         else:
             raise TypeError(f"invalid type: {type_}")
 

static/app/types/group.tsx

@@ -948,11 +948,11 @@ export interface GroupTombstone {
   actor: AvatarUser;
   culprit: string;
   id: string;
-  lastSeen: string | null;
   level: Level;
   metadata: EventMetadata;
-  timesSeen: number | null;
   type: EventOrGroupType;
+  lastSeen?: string;
+  timesSeen?: number;
   title?: string;
 }
 export interface GroupTombstoneHelper extends GroupTombstone {