Skip to content

Commit 408e1a9

Browse files
authored
feat(issue-details): Add config for hiding search bar (#103193)
1 parent d10b36a commit 408e1a9

File tree

4 files changed

+23
-18
lines changed

4 files changed

+23
-18
lines changed

static/app/utils/issueTypeConfig/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const BASE_CONFIG: IssueTypeConfig = {
4747
},
4848
defaultTimePeriod: {sinceFirstSeen: true},
4949
header: {
50-
filterBar: {enabled: true, fixedEnvironment: false},
50+
filterBar: {enabled: true, fixedEnvironment: false, searchBar: {enabled: true}},
5151
graph: {enabled: true, type: 'discover-events'},
5252
tagDistribution: {enabled: true},
5353
occurrenceSummary: {enabled: false},

static/app/utils/issueTypeConfig/metricConfig.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ const metricConfig: IssueCategoryConfigMapping = {
105105
ctaText: t('View monitor details'),
106106
},
107107
header: {
108-
filterBar: {enabled: true, fixedEnvironment: true},
108+
filterBar: {enabled: true, fixedEnvironment: true, searchBar: {enabled: false}},
109109
graph: {enabled: true, type: 'detector-history'},
110110
tagDistribution: {enabled: false},
111111
occurrenceSummary: {enabled: false},

static/app/utils/issueTypeConfig/types.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ export type IssueTypeConfig = {
7171
filterBar: DisabledWithReasonConfig & {
7272
// Display the environment filter in an inactive, locked state
7373
fixedEnvironment?: boolean;
74+
// The search bar can be hidden if the issue type does not support event filtering
75+
searchBar?: DisabledWithReasonConfig;
7476
};
7577
graph: DisabledWithReasonConfig & {
7678
type?: 'detector-history' | 'discover-events' | 'cron-checks' | 'uptime-checks';

static/app/views/issueDetails/streamline/eventDetailsHeader.tsx

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ export function EventDetailsHeader({group, event, project}: EventDetailsHeaderPr
9696
}
9797

9898
const FilterBar = theme.isChonk ? PageFilterBar : StyledPageFilterBar;
99+
const searchBarEnabled = issueTypeConfig.header.filterBar.searchBar?.enabled !== false;
99100

100101
return (
101102
<PageErrorBoundary mini message={t('There was an error loading the event filters')}>
@@ -174,22 +175,24 @@ export function EventDetailsHeader({group, event, project}: EventDetailsHeaderPr
174175
}}
175176
/>
176177
</FilterBar>
177-
<EventSearch
178-
group={group}
179-
handleSearch={query => {
180-
navigate(
181-
{...location, query: {...location.query, query}},
182-
{replace: true}
183-
);
184-
}}
185-
environments={environments}
186-
query={searchQuery}
187-
queryBuilderProps={{
188-
disallowFreeText: true,
189-
placeholder: searchText,
190-
label: searchText,
191-
}}
192-
/>
178+
{searchBarEnabled && (
179+
<EventSearch
180+
group={group}
181+
handleSearch={query => {
182+
navigate(
183+
{...location, query: {...location.query, query}},
184+
{replace: true}
185+
);
186+
}}
187+
environments={environments}
188+
query={searchQuery}
189+
queryBuilderProps={{
190+
disallowFreeText: true,
191+
placeholder: searchText,
192+
label: searchText,
193+
}}
194+
/>
195+
)}
193196
</Grid>
194197
<ToggleSidebar />
195198
</Flex>

0 commit comments

Comments
 (0)