Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudResourceContextIntegration freezing in ECS Container #2376

Open
jensenbox opened this issue Sep 16, 2023 · 1 comment · May be fixed by #4120
Open

CloudResourceContextIntegration freezing in ECS Container #2376

jensenbox opened this issue Sep 16, 2023 · 1 comment · May be fixed by #4120
Assignees
@antonpirker
Labels
Integration: Cloud Resource Context Triaged Has been looked at recently during old issue triage

Comments

@jensenbox
Copy link

How do you use Sentry?

Sentry Saas (sentry.io)

Version

1.31.0

Steps to Reproduce

Configure the CloudResourceContextIntegration without any parameters but run in an ECS container on AWS - which is running on EC2 hardware.

My suggestion is to either make the IMDS address configurable or do some detection to see if you are on ECS. There is an IMDS for ECS you could use.

At the very least make the http have a timeout so that things are not totally locked up.

Expected Result

Not freeze

Actual Result

Infinite freeze at https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/cloud_resource_context.py#L74
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Sep 16, 2023
@antonpirker
Copy link
Member

Hey @jensenbox !
Thanks for reporting this. I guess I never tested it on ECS. But it seams like a not-so-big fix. (regardless the request should not freece in the first place but just time out at some point...)

@sentrivana sentrivana added the Triaged Has been looked at recently during old issue triage label Jul 1, 2024
@antonpirker antonpirker linked a pull request Mar 6, 2025 that will close this issue
Open
@antonpirker antonpirker self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonpirker antonpirker

Labels
Integration: Cloud Resource Context Triaged Has been looked at recently during old issue triage
Projects
GitHub Issues with 👀
Status: Waiting for: Product Owner
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added timeout to HTTP requests in CloudResourceContextIntegration getsentry/sentry-python
3 participants
@jensenbox @antonpirker @sentrivana