Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python grpc.aio metadata is transformed to list #2509

Open
kindermax opened this issue Nov 15, 2023 · 1 comment · May be fixed by #3205
Open

Python grpc.aio metadata is transformed to list #2509

kindermax opened this issue Nov 15, 2023 · 1 comment · May be fixed by #3205
Labels
Integration: gRPC Triaged Has been looked at recently during old issue triage

Comments

@kindermax
Copy link

kindermax commented Nov 15, 2023 •
edited
Loading

How do you use Sentry?

Sentry Saas (sentry.io)

Version

1.35.0

Steps to Reproduce

Hi, in latest sentry-sdk release a new Client interceptor was added for grpc.aio client. The problems is that metadata is transformed into a list and it breaks all subsequent interceptors which expect metadata to be grpc.aio.Metadata object (https://github.com/grpc/grpc/blob/master/src/python/grpcio/grpc/aio/_interceptor.py#L93C14-L93C14)

Expected Result

Maybe metadata needs to be preserved as type grpc.aio.Metadata

Actual Result

For now i see error that metadata is a list
image
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Nov 15, 2023
@sentrivana
Copy link
Contributor

Thank you for reporting this @kindermax! We'll take a look.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Nov 15, 2023
@sentrivana sentrivana added Type: Bug Something isn't working Integration: gRPC labels Nov 15, 2023
fdellekart added a commit to fdellekart/sentry-python that referenced this issue Jun 26, 2024
@fdellekart
fix(grpc): Return propagate proper metadata object instead of list in…
a051186 
… client interceptor

Fixes getsentry#2509
fdellekart added a commit to fdellekart/sentry-python that referenced this issue Jun 26, 2024
@fdellekart
fix(grpc): Return propagate proper metadata object instead of list in…
451ade7 
… client interceptor

Fixes getsentry#2509
@fdellekart fdellekart linked a pull request Jun 26, 2024 that will close this issue
Open
fdellekart added a commit to fdellekart/sentry-python that referenced this issue Jul 3, 2024
@fdellekart
fix(grpc): Return propagate proper metadata object instead of list in…
c8fc77d 
… client interceptor

Fixes getsentry#2509
@antonpirker antonpirker added the Triaged Has been looked at recently during old issue triage label Jul 15, 2024
@stephanie-anderson stephanie-anderson removed the Type: Bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Integration: gRPC Triaged Has been looked at recently during old issue triage
Projects
GitHub Issues with 👀
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(grpc): Return proper metadata object instead of list in… fdellekart/sentry-python
4 participants
@antonpirker @stephanie-anderson @kindermax @sentrivana