Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option similar to shouldCreateSpanForRequest to not create certain spans. #2458

Closed
rodolfoBee opened this issue Oct 19, 2023 · 2 comments
Labels
Triaged Has been looked at recently during old issue triage

Comments

@rodolfoBee
Copy link
Member

Problem Statement

Similar to this issue, Sentry's Django automatic instrumentation can create a large number of spans that can be irrelevant for users.

The options to control which operations create spans are limited, it is a simple on/off switch for middleware, signals and cache spans.

Solution Brainstorm

The JS SDK has an option to not create spans for certain urls, the solution can be same for spans matching a criteria (description, operation, specific signal)

@antonpirker
Copy link
Member

Hey @rodolfoBee
Thanks for bringing this up. We have a traces_sampler (see https://docs.sentry.io/platforms/python/configuration/sampling/#setting-a-sampling-function) where users can specify a function that can decide what traces to keep and which ones to drop.

We could add something similar for spans. A function that gets the span as an argument and it can decide to keep or drop it.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Oct 20, 2023
@antonpirker antonpirker added the Triaged Has been looked at recently during old issue triage label Jul 15, 2024
@sentrivana
Copy link
Contributor

Closing in favor of #3859

@sentrivana sentrivana closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged Has been looked at recently during old issue triage
Projects
Archived in project
Development

No branches or pull requests

3 participants