You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should check all our existing Node instrumentation to see if we can easily emit breadcrumbs as well.
It is important not to tie this to spans, as these have no data when not sampled. Instead, where possible we need to use hooks in instrumentation to create breadcrumbs.
The content you are editing has changed. Please copy your edits and refresh the page.
Unfortunately, The only one of these otel instrumentations that has a hook that gives us the ability to add breadcrumbs with sampling disabled is fs which has a createHook!
It's also worth noting that even where we have the createHook for fs, I don't think the endHook gets called with tracing disabled so we can't breadcrumbs with the correct status depending on the result. We also have requireParentSpan: true so even with tracing enabled, you would not get breadcrumbs unless there's a parent span!
We also have this problem with the undici integration where breadcrumbs are created in the responseHook so they are not created with tracing disabled.
Description
We should check all our existing Node instrumentation to see if we can easily emit breadcrumbs as well.
It is important not to tie this to spans, as these have no data when not sampled. Instead, where possible we need to use hooks in instrumentation to create breadcrumbs.
Tasks
The text was updated successfully, but these errors were encountered: