Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Express v5 #13674

Open
mydea opened this issue Sep 12, 2024 · 2 comments
Open

Support Express v5 #13674

mydea opened this issue Sep 12, 2024 · 2 comments
Assignees
@timfish
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry

Comments

@mydea
Copy link
Member

mydea commented Sep 12, 2024

Description

It seems that Express v5 is actually close: https://github.com/expressjs/express/releases/tag/v5.0.0

We should ensure we have support for this. This means ensuring that this is supported upstream in the OTEL instrumentation.
@mydea mydea added the Package: node Issues related to the Sentry Node SDK label Sep 12, 2024
@joergbaier
Copy link

I would appreciate sentry supporting express v5. Having support here would help express finally get v5 released under the "latest" tag. 🙏

Sentry also integrates with GQL and I believe the @apollo/server + express pairing is fairly popular.
apollographql/apollo-server#7928

@timfish timfish self-assigned this Sep 16, 2024
@timfish
Copy link
Collaborator

timfish commented Sep 19, 2024

Otel PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timfish timfish

Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry
Projects
GitHub Issues with 👀 3
Status: No status
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timfish @mydea @joergbaier @Lms24 @AbhiPrasad