test: attempt to fix test

Author: logaretm

dev-packages/browser-integration-tests/utils/generatePlugin.ts

@@ -164,11 +164,15 @@ class SentryScenarioGenerationPlugin {
   public requiredIntegrations: string[] = [];
   public requiresWASMIntegration: boolean = false;
   public localOutPath: string;
+  public isFeedbackTest: boolean;
 
   private _name: string = 'SentryScenarioGenerationPlugin';
 
   public constructor(localOutPath: string) {
     this.localOutPath = localOutPath;
+    // Check if this is a feedback test by looking at the output path
+    // The path structure is: testDir/dist/uuid, and testDir includes suites/feedback/...
+    this.isFeedbackTest = localOutPath.includes('suites/feedback');
   }
 
   public apply(compiler: Compiler): void {
@@ -248,19 +252,34 @@ class SentryScenarioGenerationPlugin {
             .replace('_feedback', '');
 
           // For feedback bundle, make sure to add modal & screenshot integrations
-          if (bundleKey.includes('_feedback')) {
+          // Also symlink feedback bundles for feedback tests that use lazy loading
+          if (bundleKey.includes('_feedback') || this.isFeedbackTest) {
             ['feedback-modal', 'feedback-screenshot'].forEach(integration => {
               const fileName = `${integration}.bundle.js`;
 
-              // We add the files, but not a script tag - they are lazy-loaded
-              symlinkAsset(
-                path.resolve(
-                  PACKAGES_DIR,
-                  'feedback',
-                  BUNDLE_PATHS['feedback']?.[integrationBundleKey]?.replace('[INTEGRATION_NAME]', integration) || '',
-                ),
-                path.join(this.localOutPath, fileName),
+              // Lazy loading always requests .min.js files, so we need to use bundle_min
+              // to get the .min.js version, even if the main bundle is not minified
+              const feedbackBundleKey = integrationBundleKey === 'bundle' ? 'bundle_min' : integrationBundleKey;
+
+              const bundlePath = BUNDLE_PATHS['feedback']?.[feedbackBundleKey]?.replace(
+                '[INTEGRATION_NAME]',
+                integration,
               );
+              if (!bundlePath) {
+                throw new Error(
+                  `Could not find bundle path for feedback integration "${integration}" with bundle key "${feedbackBundleKey}" (derived from "${bundleKey}")`,
+                );
+              }
+
+              const originalPath = path.resolve(PACKAGES_DIR, 'feedback', bundlePath);
+              if (!fs.existsSync(originalPath)) {
+                throw new Error(
+                  `Feedback bundle file does not exist: ${originalPath}. Make sure to run 'yarn build:bundle' in packages/feedback first.`,
+                );
+              }
+
+              // We add the files, but not a script tag - they are lazy-loaded
+              symlinkAsset(originalPath, path.join(this.localOutPath, fileName));
             });
           }
 
@@ -279,14 +298,46 @@ class SentryScenarioGenerationPlugin {
               );
 
               if (integration === 'feedback') {
-                symlinkAsset(
-                  path.resolve(PACKAGES_DIR, 'feedback', 'build/bundles/feedback-modal.js'),
-                  path.join(this.localOutPath, 'feedback-modal.bundle.js'),
+                // Lazy loading always requests .min.js files, so we need to use bundle_min
+                // to get the .min.js version, even if the main bundle is not minified
+                const feedbackBundleKey = integrationBundleKey === 'bundle' ? 'bundle_min' : integrationBundleKey;
+
+                const modalBundlePath = BUNDLE_PATHS['feedback']?.[feedbackBundleKey]?.replace(
+                  '[INTEGRATION_NAME]',
+                  'feedback-modal',
                 );
-                symlinkAsset(
-                  path.resolve(PACKAGES_DIR, 'feedback', 'build/bundles/feedback-screenshot.js'),
-                  path.join(this.localOutPath, 'feedback-screenshot.bundle.js'),
+                if (!modalBundlePath) {
+                  throw new Error(
+                    `Could not find bundle path for feedback-modal with bundle key "${feedbackBundleKey}" (derived from "${bundleKey}")`,
+                  );
+                }
+
+                const modalOriginalPath = path.resolve(PACKAGES_DIR, 'feedback', modalBundlePath);
+                if (!fs.existsSync(modalOriginalPath)) {
+                  throw new Error(
+                    `Feedback modal bundle file does not exist: ${modalOriginalPath}. Make sure to run 'yarn build:bundle' in packages/feedback first.`,
+                  );
+                }
+
+                const screenshotBundlePath = BUNDLE_PATHS['feedback']?.[feedbackBundleKey]?.replace(
+                  '[INTEGRATION_NAME]',
+                  'feedback-screenshot',
                 );
+                if (!screenshotBundlePath) {
+                  throw new Error(
+                    `Could not find bundle path for feedback-screenshot with bundle key "${feedbackBundleKey}" (derived from "${bundleKey}")`,
+                  );
+                }
+
+                const screenshotOriginalPath = path.resolve(PACKAGES_DIR, 'feedback', screenshotBundlePath);
+                if (!fs.existsSync(screenshotOriginalPath)) {
+                  throw new Error(
+                    `Feedback screenshot bundle file does not exist: ${screenshotOriginalPath}. Make sure to run 'yarn build:bundle' in packages/feedback first.`,
+                  );
+                }
+
+                symlinkAsset(modalOriginalPath, path.join(this.localOutPath, 'feedback-modal.bundle.js'));
+                symlinkAsset(screenshotOriginalPath, path.join(this.localOutPath, 'feedback-screenshot.bundle.js'));
               }
 
               const integrationObject = createHtmlTagObject('script', {

dev-packages/browser-integration-tests/utils/staticAssets.ts

@@ -24,9 +24,19 @@ export function addStaticAsset(localOutPath: string, fileName: string, cb: () =>
 
 export function symlinkAsset(originalPath: string, targetPath: string): void {
   try {
+    // Try hard link first (faster, works on same filesystem)
     fs.linkSync(originalPath, targetPath);
-  } catch {
-    // ignore errors here, probably means the file already exists
-    // Since we always build into a new directory for each test, we can safely ignore this
+  } catch (err) {
+    // If hard link fails (e.g., cross-filesystem in CI), fall back to copying
+    // This can happen in CI environments where source and target are on different filesystems
+    try {
+      fs.copyFileSync(originalPath, targetPath);
+    } catch (copyErr) {
+      // If copy also fails, it might mean the file already exists (from a previous test run)
+      // Since we always build into a new directory for each test, we can safely ignore this
+      if ((copyErr as NodeJS.ErrnoException).code !== 'EEXIST') {
+        throw copyErr;
+      }
+    }
   }
 }