Skip to content

Commit 1cf7f7f

Browse files
committed
Merge branch 'develop' into feat/spotlight-environment-variable-support
2 parents 870be3b + b6eb205 commit 1cf7f7f

File tree

597 files changed

+17330
-4398
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

597 files changed

+17330
-4398
lines changed

.craft.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ targets:
153153
- nodejs18.x
154154
- nodejs20.x
155155
- nodejs22.x
156+
- nodejs24.x
156157
license: MIT
157158

158159
# CDN Bundle Target

.cursor/BUGBOT.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ Do not flag the issues below if they appear in tests.
3232

3333
- When calling any `startSpan` API (`startInactiveSpan`, `startSpanManual`, etc), always ensure that the following span attributes are set:
3434
- `SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN` (`'sentry.origin'`) with a proper span origin
35+
- a proper origin must only contain [a-z], [A-Z], [0-9], `_` and `.` characters.
36+
- flag any non-conforming origin values as invalid and link to the trace origin specification (https://develop.sentry.dev/sdk/telemetry/traces/trace-origin/)
3537
- `SEMANTIC_ATTRIBUTE_SENTRY_OP` (`'sentry.op'`) with a proper span op
38+
- Span ops should be lower case only, and use snake_case. The `.` character is used to delimit op parts.
39+
- flag any non-conforming origin values as invalid and link to the span op specification (https://develop.sentry.dev/sdk/telemetry/traces/span-operations/)
3640
- When calling `captureException`, always make sure that the `mechanism` is set:
3741
- `handled`: must be set to `true` or `false`
3842
- `type`: must be set to a proper origin (i.e. identify the integration and part in the integration that caught the exception).
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# Bump OpenTelemetry instrumentations
2+
3+
1. Ensure you're on the `develop` branch with the latest changes:
4+
- If you have unsaved changes, stash them with `git stash -u`.
5+
- If you're on a different branch than `develop`, check out the develop branch using `git checkout develop`.
6+
- Pull the latest updates from the remote repository by running `git pull origin develop`.
7+
8+
2. Create a new branch `bump-otel-{yyyy-mm-dd}`, e.g. `bump-otel-2025-03-03`
9+
10+
3. Create a new empty commit with the commit message `feat(deps): Bump OpenTelemetry instrumentations`
11+
12+
4. Push the branch and create a draft PR, note down the PR number as {PR_NUMBER}
13+
14+
5. Create a changelog entry in `CHANGELOG.md` under
15+
`- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott` with the following format:
16+
`- feat(deps): Bump OpenTelemetry instrumentations ([#{PR_NUMBER}](https://github.com/getsentry/sentry-javascript/pull/{PR_NUMBER}))`
17+
18+
6. Find the "Upgrade OpenTelemetry instrumentations" rule in `.cursor/rules/upgrade_opentelemetry_instrumentations` and
19+
follow those complete instructions step by step.
20+
- Create one commit per package in `packages/**` with the commit message
21+
`Bump OpenTelemetry instrumentations for {SDK}`, e.g. `Bump OpenTelemetry instrumentation for @sentry/node`
22+
23+
- For each OpenTelemetry dependency bump, record an entry in the changelog with the format indented under the main
24+
entry created in step 5: `- Bump @opentelemetry/{instrumentation} from {previous_version} to {new_version}`, e.g.
25+
`- Bump @opentelemetry/instrumentation from 0.204.0 to 0.207.0` **CRITICAL**: Avoid duplicated entries, e.g. if we
26+
bump @opentelemetry/instrumentation in two packages, keep a single changelog entry.
27+
28+
7. Regenerate the yarn lockfile and run `yarn yarn-deduplicate`
29+
30+
8. Run `yarn fix` to fix all formatting issues
31+
32+
9. Finally update the PR description to list all dependency bumps
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
---
2+
description: Use this rule if you are looking to grade OpenTelemetry instrumentations for the Sentry JavaScript SDKs
3+
globs: *
4+
alwaysApply: false
5+
---
6+
7+
# Upgrading OpenTelemetry instrumentations
8+
9+
1. For every package in packages/\*\*:
10+
- When upgrading dependencies for OpenTelemetry instrumentations we need to first upgrade `@opentelemetry/instrumentation` to the latest version.
11+
**CRITICAL**: `@opentelemetry/instrumentation` MUST NOT include any breaking changes.
12+
Read through the changelog of `@opentelemetry/instrumentation` to figure out if breaking changes are included and fail with the reason if it does include breaking changes.
13+
You can find the changelog at `https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/CHANGELOG.md`
14+
15+
- After successfully upgrading `@opentelemetry/instrumentation` upgrade all `@opentelemetry/instrumentation-{instrumentation}` packages, e.g. `@opentelemetry/instrumentation-pg`
16+
**CRITICAL**: `@opentelemetry/instrumentation-{instrumentation}` MUST NOT include any breaking changes.
17+
Read through the changelog of `@opentelemetry/instrumentation-{instrumentation}` to figure out if breaking changes are included and fail with the reason if it does including breaking changes.
18+
You can find the changelogs at `https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/packages/instrumentation-{instrumentation}/CHANGELOG.md`.
19+
20+
- Finally, upgrade third party instrumentations to their latest versions, these are currently:
21+
- @prisma/instrumentation
22+
23+
**CRITICAL**: Upgrades to third party instrumentations MUST NOT include breaking changes.
24+
Read through the changelog of each third party instrumentation to figure out if breaking changes are included and fail with the reason if it does include breaking changes.
25+
26+
2. For packages and apps in dev-packages/\*\*:
27+
- If an app depends on `@opentelemetry/instrumentation` >= 0.200.x upgrade it to the latest version.
28+
**CRITICAL**: `@opentelemetry/instrumentation` MUST NOT include any breaking changes.
29+
30+
- If an app depends on `@opentelemetry/instrumentation-http` >= 0.200.x upgrade it to the latest version.
31+
**CRITICAL**: `@opentelemetry/instrumentation-http` MUST NOT include any breaking changes.
32+
33+
3. Generate a new yarn lock file.

.github/dependabot.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,15 @@ updates:
1414
interval: 'weekly'
1515
allow:
1616
- dependency-name: '@sentry/*'
17-
- dependency-name: '@opentelemetry/*'
18-
- dependency-name: '@prisma/instrumentation'
1917
- dependency-name: '@playwright/test'
18+
- dependency-name: '@opentelemetry/*'
19+
ignore:
20+
- dependency-name: '@opentelemetry/instrumentation'
21+
- dependency-name: '@opentelemetry/instrumentation-*'
22+
groups:
23+
opentelemetry:
24+
patterns:
25+
- '@opentelemetry/*'
2026
versioning-strategy: increase
2127
commit-message:
2228
prefix: feat

.github/dependency-review-config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,5 @@ allow-ghsas:
99
- GHSA-v784-fjjh-f8r4
1010
# Next.js Cache poisoning - We require a vulnerable version for E2E testing
1111
- GHSA-gp8f-8m3g-qvj9
12+
# devalue vulnerability - this is just used by nuxt & astro as transitive dependency
13+
- GHSA-vj54-72f3-p5jv

.github/workflows/auto-release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ jobs:
1515
steps:
1616
- name: Get auth token
1717
id: token
18-
uses: actions/create-github-app-token@a8d616148505b5069dccd32f177bb87d7f39123b # v2.1.1
18+
uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
1919
with:
2020
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
2121
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}
2222

23-
- uses: actions/checkout@v5
23+
- uses: actions/checkout@v6
2424
with:
2525
token: ${{ steps.token.outputs.token }}
2626
fetch-depth: 0
@@ -42,7 +42,7 @@ jobs:
4242
echo "version=$version" >> $GITHUB_OUTPUT
4343
4444
- name: Set up Node
45-
uses: actions/setup-node@v4
45+
uses: actions/setup-node@v6
4646
with:
4747
node-version-file: 'package.json'
4848

0 commit comments

Comments
 (0)