Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: manual ttid widget #2477

Merged
merged 6 commits into from
Dec 12, 2024
Merged

deprecate: manual ttid widget #2477

merged 6 commits into from
Dec 12, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Dec 10, 2024

Closes #2449

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (dc6fc46) to head (7baa6a8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
+ Coverage   86.97%   91.52%   +4.55%     
==========================================
  Files         264       87     -177     
  Lines        9390     3045    -6345     
==========================================
- Hits         8167     2787    -5380     
+ Misses       1223      258     -965     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 443.65 ms 489.59 ms 45.94 ms
Size 6.46 MiB 7.49 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a609134 350.12 ms 404.12 ms 54.00 ms
211a7aa 324.19 ms 393.26 ms 69.07 ms
64af39c 386.80 ms 471.11 ms 84.31 ms
f1314d5 313.89 ms 372.10 ms 58.21 ms
117d988 376.32 ms 450.85 ms 74.53 ms
acbd5d3 367.53 ms 428.76 ms 61.23 ms
be7a831 476.15 ms 548.53 ms 72.38 ms
d5fb969 420.83 ms 490.88 ms 70.05 ms
bd1b990 343.82 ms 410.54 ms 66.72 ms
61e71ec 343.94 ms 410.59 ms 66.66 ms

App size

Revision Plain With Sentry Diff
a609134 5.94 MiB 6.95 MiB 1.01 MiB
211a7aa 6.06 MiB 7.03 MiB 997.24 KiB
64af39c 6.27 MiB 7.20 MiB 958.83 KiB
f1314d5 6.06 MiB 7.10 MiB 1.04 MiB
117d988 6.33 MiB 7.26 MiB 947.03 KiB
acbd5d3 6.35 MiB 7.35 MiB 1017.84 KiB
be7a831 6.49 MiB 7.56 MiB 1.07 MiB
d5fb969 6.35 MiB 7.35 MiB 1021.16 KiB
bd1b990 6.33 MiB 7.26 MiB 950.37 KiB
61e71ec 6.34 MiB 7.28 MiB 966.26 KiB

Previous results on branch: deprecate/manual-ttid-widget

Startup times

Revision Plain With Sentry Diff
873b981 483.78 ms 492.55 ms 8.77 ms
c4ad875 497.15 ms 530.31 ms 33.16 ms
9cfcba3 448.73 ms 488.69 ms 39.95 ms
c60f914 691.30 ms 749.06 ms 57.76 ms

App size

Revision Plain With Sentry Diff
873b981 6.49 MiB 7.57 MiB 1.08 MiB
c4ad875 6.49 MiB 7.57 MiB 1.08 MiB
9cfcba3 6.49 MiB 7.57 MiB 1.08 MiB
c60f914 6.49 MiB 7.57 MiB 1.08 MiB

Copy link
Contributor

github-actions bot commented Dec 10, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1260.86 ms 1281.04 ms 20.18 ms
Size 8.42 MiB 9.83 MiB 1.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8f88a49 1252.92 ms 1277.00 ms 24.08 ms
74e1fdd 1240.08 ms 1258.28 ms 18.19 ms
8609bd8 1267.16 ms 1291.39 ms 24.22 ms
5d2b46d 1244.31 ms 1245.16 ms 0.86 ms
cd16818 1254.78 ms 1267.76 ms 12.98 ms
f1314d5 1246.46 ms 1270.92 ms 24.46 ms
905bf99 1240.84 ms 1271.47 ms 30.63 ms
b728df4 1287.43 ms 1293.94 ms 6.51 ms
eecbbca 1264.90 ms 1286.33 ms 21.43 ms
2f8f173 1280.61 ms 1292.20 ms 11.59 ms

App size

Revision Plain With Sentry Diff
8f88a49 8.32 MiB 9.40 MiB 1.07 MiB
74e1fdd 8.32 MiB 9.38 MiB 1.06 MiB
8609bd8 8.28 MiB 9.34 MiB 1.06 MiB
5d2b46d 8.29 MiB 9.36 MiB 1.07 MiB
cd16818 8.28 MiB 9.33 MiB 1.05 MiB
f1314d5 8.10 MiB 9.08 MiB 1004.30 KiB
905bf99 8.38 MiB 9.74 MiB 1.36 MiB
b728df4 8.15 MiB 9.15 MiB 1020.72 KiB
eecbbca 8.15 MiB 9.10 MiB 965.26 KiB
2f8f173 8.15 MiB 9.13 MiB 1000.39 KiB

Previous results on branch: deprecate/manual-ttid-widget

Startup times

Revision Plain With Sentry Diff
873b981 1249.59 ms 1279.83 ms 30.24 ms
9cfcba3 1239.06 ms 1270.88 ms 31.81 ms
c60f914 1225.17 ms 1239.71 ms 14.54 ms
c4ad875 1255.24 ms 1278.45 ms 23.20 ms

App size

Revision Plain With Sentry Diff
873b981 8.38 MiB 9.78 MiB 1.40 MiB
9cfcba3 8.38 MiB 9.78 MiB 1.40 MiB
c60f914 8.38 MiB 9.78 MiB 1.40 MiB
c4ad875 8.38 MiB 9.78 MiB 1.41 MiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good.

flutter/test/navigation/time_to_display_tracker_test.dart Outdated Show resolved Hide resolved
@buenaflor buenaflor merged commit d44ba48 into main Dec 12, 2024
51 checks passed
@buenaflor buenaflor deleted the deprecate/manual-ttid-widget branch December 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate manual TTID / SentryDisplayWidget
2 participants