-
-
Notifications
You must be signed in to change notification settings - Fork 257
Add mechanism to differentiate between obfuscated and non-obfuscated builds (Dart) and create internal stats board #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Assigned this to you @denrase we want to be able to query how many events were obfuscated or not the easiest way for that is to only add the I have a draft PR open, you can continue it there or take it as inspiration (or ditch it if it doesnt make sense). This issue should also depend on the debug ID SDK side implementation as there are some changes there. Some notes:
|
Just to clarify, the way I understand it, we have the following combinations:
Even though |
Yeah, that's fine. I've already done tests and it's possible to obfuscate on desktop on Dart only, we just haven't implemented it yet. Generally I don't want to overthink this, this is going to be internal any way. What matters to me is that we don't add the integration where it doesnt make sense which in turn will let us accurately see which apps are obfuscated or not in the stats page. For web it doesn't matter to differentiate because if you deploy a flutter web app it's always going to be minified. I'm also fine ignoring web here and only applying |
Also this can be improved in the SDK, this doesn't do anything on web and should not be added there. |
Uh oh!
There was an error while loading. Please reload this page.
Having internal statistics about how many people actually use dart obfuscation in their apps is helpful. This information should be added in such a way so we can query it in our dashboards, e.g only adding the
LoadNativeDebugImagesIntegration
if it is an obfuscated event. Currently we always add this integration regardless of build type so it doesn't help us.-> Loading debug images integration should only be done for obfuscated builds.
The text was updated successfully, but these errors were encountered: