Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove linker settings from Package.swift #3188

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Jul 26, 2023

📜 Description

Removes C++ and Z linker settings from Package.swift.
It seems this is not necessary since it don't break the build for Xcode 14,
also this will be necessary for Xcode 15.

💡 Motivation and Context

closes #3122

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@brustolin brustolin marked this pull request as ready for review July 26, 2023 11:03
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation warnings and errors when using Xcode 15 Beta
2 participants