-
-
Notifications
You must be signed in to change notification settings - Fork 372
Closed
Description
Note
The pull request "fix(session-replay): Include layer background color when checking if a view is opaque" was created by @itaybre but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
📜 Description
Improve check for view opaqueness
💡 Motivation and Context
User's (or libraries) can override UIView's backgroundColor and report a report different value (example).
Since UIView are wrappers around CALayer. we should consider using the actual layers properties too.
This is draft because I have to verify this actually works
💚 How did you test it?
Run the app with Session Replay enabled and view the output.
Still needs more tests with popups and custom views
📝 Checklist
You have to check all boxes before merging:
- I added tests to verify the changes.
- No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - I updated the docs if needed.
- I updated the wizard if needed.
- Review from the native team if needed.
- No breaking change or entry added to the changelog.
- No breaking change for hybrid SDKs or communicated to hybrid SDKs.
Metadata
Metadata
Assignees
Labels
No labels