Skip to content

ref: SentryClient and SentryHub in Swift #6630

@github-actions

Description

@github-actions

Note

The pull request "ref: SentryClient and SentryHub in Swift" was created by @noahsmartin but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.

This PR looks big in the line count, but only because it renamed some things. The real changes are just SentryId.h/.m, SentryClient.swift, and SentryHub.swift. All of these are pretty small.

Refactors the public interface of SentryClient and SentryHub to be in Swift. The implementation doesn't change at all I keep the old old classes around and just renamed them to SentryClientInternal and SentryHubInternal. This unblocks using SPM without any risk of a big Swift migration, and lets us migrate them when we want without affecting the public API.

Also converts SentryId to ObjC which is required for SPM, and lets us delete SentryIdWrapper. We can convert it to Swift again once all of the classes depending on it in the public API are also in Swift. Basically, this should be the last part of the public API to be in Swift.

#skip-changelog

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions