-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation warnings and errors when using Xcode 15 Beta #3122
Comments
Thanks @DenTelezhkin for pointing this out. We're going to investigate. |
Removing the |
Interesting, I get a warning like this on another Swift package, Pusher Web Socket issue, however mine doesn't fail compliation. |
Update: Compilation error is fixed in Xcode 15 Beta 3. There are a ton of new warnings though, a lot of them about Sentry, now present not only on iOS, but on macOS as well. |
I can reproduce the issue by compiling an empty sample project that includes Sentry via SPM and compiling it for a plugged-in device. As you stated @DenTelezhkin, they are now compiler warnings with Xcode 15 Beta 3. We still have to investigate how we can fix these. Build Warnings
|
From my understanding, the warning message |
I have a suspicion that I can't test right now. You may try to remove this from the package to see if it works. I would call this an Apple bug, they definitely should check for duplicity. |
@brustolin I tried removing linker settings in my fork (https://github.com/DenTelezhkin/sentry-cocoa/tree/feature/xcode-15-spm-support), unfortunately, it did not help, warnings remain. I had a thought, that maybe because C++ language standard is included in Package.swift, Sentry and Xcode compiler use different C++ language versions, which causes a conflict. However, i cannot test this theory, as removing And I'm with you, definitely seems like an Apple bug at this moment. |
Hi guys. I don't use sentry-cocoa but I have the same warning in my project in Xcode 15 beta 3. I think it is a beta problem |
The issue persists in XCode 15 Beta 3. |
@mezhevikin and @waydabber, do you get warnings or build errors? We are aware that they are warnings, but as pointed out in #3122 (comment) and #3122 (comment), we assume the warnings could be bugs from Apple, and they might be resolved in future Xcode releases. |
Warnings are still there for Xcode 15 Beta 4. |
This warning showing on Xcode 15 beta 4. |
This is still happening in Xcode Version 15.0 beta 5 (15A5209g) |
Well, actually on Xcode 15 beta 5 much of the warnings have disappeared. There are only two warnings left:
They appear in every binary Sentry is imported into. |
+1. |
I could not reproduce
And I believe this will also solve the |
Hello @AlexHadfield, I just noticed your problem is for WatchOS. |
@brustolin is this fix only for SPM ? Using cocoapods i'm still seeing the warning |
@soucolline You're right, this was not changed for cocoapod yet. I will see if it is possible. |
@soucolline this was fixed in #3312 and will be available in our next release. |
Thanks a lot for keeping me updated @brustolin |
Platform
iOS
Installed
Swift Package Manager
Version
8.8.0
Steps to Reproduce
When compiling on device (compilation on simulator works fine), there are a bunch of new warnings, and with specific project configuration, compilation error when using Sentry.
Update: Compilation error is fixed in Xcode 15 Beta 3.
Warnings can be reproduced by doing the following:
Observe following warnings:
However, if project setup is as follows: App -> Framework -> Sentry, warnings are the same, but there is now a compile error:
This is probably an Xcode beta issue, and may be mitigated in future betas of Xcode 15, however as this is reproducible in two beta releases already, I wanted to file this issue for visibility, as there might be something i'm missing here.
Expected Result
Compilation succeeds
Actual Result
Compliation failed.
Are you willing to submit a PR?
Currently no, as I'm not certain how this issue can be fixed (and if this is a Sentry issue at all)
The text was updated successfully, but these errors were encountered: