Skip to content

Commit c169cf5

Browse files
Merge branch 'main' into ref/extract-trace-propagation
2 parents 988c866 + fa9a4bb commit c169cf5

File tree

51 files changed

+351
-325
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+351
-325
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,9 @@ jobs:
130130
fail-fast: false
131131
matrix:
132132
include:
133-
- name: iOS 18
134-
runs-on: macos-15
135-
platform: "iOS"
136-
xcode: "16.4"
137-
device: "iPhone 16 Pro"
138-
test-destination-os: "18.5"
139-
133+
# Running the tests with simulators is incredibly flaky. Our assumption is that simulators might have difficulties
134+
# with communicating with the test server in CI.
135+
# We are going to add these back in https://github.com/getsentry/sentry-cocoa/issues/6361
140136
- name: macOS 15
141137
runs-on: macos-15
142138
platform: "macOS"

CHANGELOG-v9.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ Removes deprecated SentryDebugImageProvider class (#5598)
99
Makes app hang tracking V2 the default and removes the option to enable/disable it (#5615)
1010
Removes segment property on SentryUser, SentryBaggage, and SentryTraceContext (#5638)
1111
Removes public SentrySerializable conformance from many public models (#5636, #5840, #5982)
12-
Removes Decodable conformances from the public API of model classes (#5691)
1312
Removes enableTracing property from SentryOptions (#5694)
1413
Removes deprecated `setExtraValue` from SentrySpan (#5864)
1514
Removes `integrations` property from `SentryOptions` (#5749)

CHANGELOG.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,20 @@
44

55
### Breaking Changes
66

7-
Removes deprecated user feedback API, this is replaced with the new feedback API (#5591)
8-
Removes `enablePerformanceV2` option and makes this the default. The app start duration will now finish when the first frame is drawn instead of when the OS posts the UIWindowDidBecomeVisibleNotification. (#6008)
7+
- Moves `SentryEventDecoder` to SPI (#6365)
8+
- Makes `PreviewRedactOptions`, `SentryProfileOptions`, `SentryRedactViewHelper`, `SentryViewScreenshotOptions`, `SentryReplayOptions`, `SentryUserFeedbackConfiguration`, `SentryUserFeedbackFormConfiguration`, `SentryUserFeedbackThemeConfiguration`, `SentryUserFeedbackWidgetConfiguration`, `SentryFeedback`, and `SentryExperimentalOptions` `final` (#6365)
9+
- Removes Decodable conformances from the public API of model classes (#5691)
10+
- Removes deprecated user feedback API, this is replaced with the new feedback API (#5591)
11+
- Removes `enablePerformanceV2` option and makes this the default. The app start duration will now finish when the first frame is drawn instead of when the OS posts the UIWindowDidBecomeVisibleNotification. (#6008)
912

1013
### Features
1114

1215
- Add SentryDistribution as Swift Package Manager target (#6149)
1316

1417
### Fixes
1518

16-
Fixes warnings about minimum OS version being lower than Xcode supported version (#5591)
19+
- Fixes warnings about minimum OS version being lower than Xcode supported version (#5591)
20+
- Fix rendering method for fast view rendering (#6360)
1721

1822
## 8.56.2
1923

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ GEM
173173
xcodeproj (>= 1.13.0, < 2.0.0)
174174
xcpretty (~> 0.4.1)
175175
xcpretty-travis-formatter (>= 0.0.3, < 2.0.0)
176-
fastlane-plugin-sentry (1.33.0)
176+
fastlane-plugin-sentry (1.34.0)
177177
os (~> 1.1, >= 1.1.4)
178178
fastlane-sirp (1.0.0)
179179
sysrandom (~> 1.0)

Sources/Sentry/Public/SentryThread.h

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,12 @@ NS_ASSUME_NONNULL_BEGIN
2020

2121
SENTRY_NO_INIT
2222

23-
#if SDK_V9
2423
/**
2524
* Number of the thread.
2625
*
2726
* Can be nil for threads in recrash reports where the thread index information is not available.
2827
*/
2928
@property (nullable, nonatomic, copy) NSNumber *threadId;
30-
#else
31-
/**
32-
* Number of the thread
33-
*/
34-
@property (nonatomic, copy) NSNumber *threadId;
35-
#endif // SDK_V9
3629

3730
/**
3831
* Name (if available) of the thread
@@ -59,21 +52,12 @@ SENTRY_NO_INIT
5952
*/
6053
@property (nullable, nonatomic, copy) NSNumber *isMain;
6154

62-
#if SDK_V9
6355
/**
6456
* Initializes a SentryThread with its id
6557
* @param threadId NSNumber or nil if thread index is not available (e.g., recrash reports)
6658
* @return SentryThread
6759
*/
6860
- (instancetype)initWithThreadId:(nullable NSNumber *)threadId;
69-
#else
70-
/**
71-
* Initializes a SentryThread with its id
72-
* @param threadId NSNumber
73-
* @return SentryThread
74-
*/
75-
- (instancetype)initWithThreadId:(NSNumber *)threadId;
76-
#endif // SDK_V9
7761

7862
@end
7963

Sources/Sentry/SentryBreadcrumb.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ - (BOOL)isEqual:(id _Nullable)other
7777
{
7878
if (other == self)
7979
return YES;
80-
if (!other || ![[other class] isEqual:[self class]])
80+
if (!other || ![other isKindOfClass:[SentryBreadcrumb class]])
8181
return NO;
8282

8383
return [self isEqualToBreadcrumb:SENTRY_UNWRAP_NULLABLE(SentryBreadcrumb, other)];

Sources/Sentry/SentryGeo.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ - (BOOL)isEqual:(id _Nullable)other
4343
if (other == self) {
4444
return YES;
4545
}
46-
if (!other || ![[other class] isEqual:[self class]]) {
46+
if (!other || ![other isKindOfClass:[SentryGeo class]]) {
4747
return NO;
4848
}
4949

Sources/Sentry/SentryThread.mm

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,7 @@
1212

1313
@implementation SentryThread
1414

15-
#if SDK_V9
1615
- (instancetype)initWithThreadId:(nullable NSNumber *)threadId
17-
#else
18-
- (instancetype)initWithThreadId:(NSNumber *)threadId
19-
#endif // SDK_V9
2016
{
2117
self = [super init];
2218
if (self) {

Sources/Sentry/SentryUser.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ - (BOOL)isEqual:(id _Nullable)other
122122
if (other == self) {
123123
return YES;
124124
}
125-
if (!other || ![[other class] isEqual:[self class]]) {
125+
if (!other || ![other isKindOfClass:[SentryUser class]]) {
126126
return NO;
127127
}
128128

Sources/SentrySwiftUI/Preview/PreviewRedactOptions.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Sentry
66
*
77
* - Note: See ``SentryReplayOptions.DefaultValues`` for the default values of each parameter.
88
*/
9-
public class PreviewRedactOptions: SentryRedactOptions {
9+
public final class PreviewRedactOptions: SentryRedactOptions {
1010
/**
1111
* Flag to redact all text in the app by drawing a rectangle over it.
1212
*

0 commit comments

Comments
 (0)