Skip to content

Commit 4446d9f

Browse files
committed
Merge branch 'main' into denrase/logs-in-hub-and-client
2 parents 4533b76 + d14bd20 commit 4446d9f

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ jobs:
217217
unit-tests:
218218
name: Unit ${{matrix.name}}
219219
runs-on: ${{matrix.runs-on}}
220-
timeout-minutes: 20
220+
timeout-minutes: ${{ matrix.timeout || 20 }}
221221
needs: files-changed
222222
if: needs.files-changed.outputs.run_unit_tests_for_prs == 'true'
223223

@@ -257,6 +257,8 @@ jobs:
257257
create_device: true
258258
device: "iPhone 17 Pro"
259259
scheme: "Sentry"
260+
# This runner seems to be slower than the others, so we give it more time because otherwise it frequently times out. The build step often alone takes 10 minutes and also booting the simulator takes a while.
261+
timeout: 30
260262

261263
# We don't run the unit tests on macOS 13 cause we run them on all on GH actions available iOS versions.
262264
# The chance of missing a bug solely on tvOS 16 that doesn't occur on iOS, macOS 12 or macOS 14 is minimal.

Plans/Sentry_Base.xctestplan

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"SentryANRTrackerTests\/testMultipleListeners()",
3232
"SentryCoreDataTrackerTests\/testFetchRequestBackgroundThread()",
3333
"SentryCoreDataTrackerTests\/testSaveBackgroundThread()",
34+
"SentryCrashBinaryImageCacheTests\/testRemoveImageFromBeginning",
3435
"SentryCrashIntegrationTests\/testStartUpCrash_CallsFlush()",
3536
"SentryCrashReportStore_Tests\/testCrashReportCount1",
3637
"SentryCrashReportStore_Tests\/testDeleteAllReports",

Plans/Sentry_Flaky.xctestplan

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"testTargets" : [
1717
{
1818
"selectedTests" : [
19+
"SentryCrashBinaryImageCacheTests\/testRemoveImageFromBeginning",
1920
"SentryHttpTransportFlushIntegrationTests"
2021
],
2122
"target" : {

0 commit comments

Comments
 (0)