Skip to content

chore(proguard): Remove --android-manifest argument #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: szokeasaurusrex/remove-auth-key
Choose a base branch
from
Open

chore(proguard): Remove --android-manifest argument #2940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ we should rename this section to "Unreleased" -->
- `SENTRY_API_KEY` environment variable
- `api_key` configuration file field
- `apiKey` option in the JavaScript API
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, and `--version-code` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, and `--android-manifest` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.

### Improvements

Expand Down
18 changes: 0 additions & 18 deletions src/commands/upload_proguard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,6 @@ pub fn make_command(command: Command) -> Command {
proguard UUIDs into a properties file.",
),
)
.arg(
Arg::new("android_manifest")
.long("android-manifest")
.value_name("PATH")
.hide(true)
.help(
"[DEPRECATED] This flag is a no-op, scheduled \
for removal in Sentry CLI 3.0.0.",
),
)
.arg(
Arg::new("write_properties")
.long("write-properties")
Expand Down Expand Up @@ -100,14 +90,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
);
}

if matches.get_one::<String>("android_manifest").is_some() {
log::warn!(
"[DEPRECATION NOTICE] The --android-manifest argument is deprecated, \
and is scheduled for removal in Sentry CLI 3.0.0. \
The argument is a no-op."
);
}

let paths: Vec<_> = match matches.get_many::<String>("paths") {
Some(paths) => paths.collect(),
None => {
Expand Down
Loading